Instantiate endpoint for deploymentconfigs #9349

0xmichalis · 2016-06-15T17:06:21Z

Add an instantiate endpoint for processing deployment configs and plug it in the trigger controller. The trigger controller has been reconciling deployment configs on image stream updates since #9485 meaning the image change controller is obsolete now.

Partially fixes #6980.
Fixes #4359

@mfojtik @smarterclayton @ironcladlou

0xmichalis · 2016-06-15T17:10:11Z

@openshift/api-review

deads2k · 2016-06-15T18:41:28Z

pkg/cmd/server/bootstrappolicy/policy.go

@@ -277,7 +277,7 @@ func GetBootstrapClusterRoles() []authorizationapi.ClusterRole {

 				authorizationapi.NewRule(read...).Groups(buildGroup).Resources("builds", "buildconfigs", "buildconfigs/webhooks").RuleOrDie(),
 				authorizationapi.NewRule(read...).Groups(buildGroup).Resources("builds/log").RuleOrDie(),
-
+				// Why the View role has generatedeploymentconfigs, deploymentconfigrollbacks ?


oversight. If they aren't needed, remove them.

0xmichalis · 2016-06-16T14:45:58Z

@deads2k any idea why I am getting a 405 ("the server does not allow this method on the requested resource") when hitting the new endpoint?

Fixed, I had to switch from POST to PUT...

0xmichalis · 2016-06-16T16:38:12Z

So I've got this working fine but the trigger controller needs image stream caches if it's going to use the endpoint and process the config without the need for the image change controller. I will work on a separate pull that adds those caches.

0xmichalis · 2016-06-24T15:30:02Z

pkg/deploy/registry/instantiate/rest.go

+
+		// Tag references are already validated
+		name, tag, _ := imageapi.SplitImageStreamTag(params.From.Name)
+		istag, err := r.istn.ImageStreamTags(params.From.Namespace).Get(name, tag)


@smarterclayton @miminar @soltysh is there any reason not to use the image stream tag client instead of the image stream client?

I don't know of any, unless you already work with image stream client on some other place.

Primary reason is efficiency - if you need two tags from the same repo (two different triggers) then IST is 4 times the number of calls (each IST is two loads from etcd). For infrastructure code if you are looking up tags you should generally call IS

Ok, switched back to an image stream client.

0xmichalis · 2016-06-24T15:30:16Z

[test]

0xmichalis · 2016-07-01T12:52:23Z

@openshift/api-review I want to move forward with this. Can I get a review for the API?

smarterclayton · 2016-07-01T15:06:48Z

pkg/deploy/api/types.go

+	// Manual should always try to force a new deployment to run. This is meant to be used
+	// by all clients.
+	Manual bool
+}


I'd probably prefer "ForceDeployment" - "If true, a deployment is always created by incrementing the generation ..."

What generation has to do with this? We increment generation on any spec change (and on latestVersion changes)

Yes. This is forcing a generation / latestVersion change, which is why we want to explicitly state that in the godoc and have the name reflect the change. manual doesn't mean anything and we try not to use it.

Regarding the name, how about Force (that's what I was using before switching to Manual) ? In a similar fashion to not making Name (and any field name for that matter) verbose since they are namescoped by DeploymentRequest.

0xmichalis · 2016-07-07T10:37:04Z

@tnozicka this is the pull we talked about. oc rollout latest will be added in a separate as soon as this merges. Ref #9298

smarterclayton · 2016-09-26T16:05:06Z

API approved.

0xmichalis · 2016-09-27T10:09:27Z

@deads2k ptal in 66fec4c

mfojtik · 2016-09-27T11:53:57Z

@Kargakis

@deads2k ptal in 66fec4c

404 :-(

deads2k · 2016-09-27T12:32:33Z

@deads2k ptal in 66fec4c

Yeah, that makes me happier. Thanks.

0xmichalis · 2016-09-27T21:55:09Z

(2) Deploy most recently available image

0xmichalis · 2016-09-27T22:53:53Z

Still can't get past protobuf generation - @smarterclayton do I need to use the same protoc version as the one used in Jenkins? Are there any other pitfalls I need to be aware of for generating protobuf (used to work in the past, not sure why this time is a special one) ?

smarterclayton · 2016-09-28T17:08:23Z

Run:

OS_BUILD_ENV_PRESERVE=. hack/env hack/update-generated-protobuf.sh

On Tue, Sep 27, 2016 at 6:53 PM, Michail Kargakis notifications@github.com
wrote:

Still can't get past protobuf generation - @smarterclayton
https://github.com/smarterclayton do I need to use the same protoc
version as the one used in Jenkins? Are there any other pitfalls I need to
be aware of for generating protobuf (used to work in the past, not sure why
this time is a special one) ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9349 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p6Hvut9tncxouLg48yw_ZJ9r9Sawks5quZ6EgaJpZM4I2lSD
.

This was a bad idea anyway and now we can provide users with 'oc rollout latest' which will manually do the resolving for them.

openshift-bot · 2016-09-29T16:57:33Z

Evaluated for origin test up to 2f86bfa

openshift-bot · 2016-09-29T18:15:29Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9498/)

0xmichalis · 2016-09-29T18:55:22Z

@mfojtik @smarterclayton any final comments

0xmichalis · 2016-10-03T09:09:58Z

I will merge this later today if there are no other comments, need to leave room for merging the Conditions PR until Wednesday (devcut)

mfojtik · 2016-10-04T07:59:50Z

LGTM

0xmichalis · 2016-10-04T08:36:01Z

[merge]

openshift-bot · 2016-10-04T08:37:26Z

Evaluated for origin merge up to 2f86bfa

openshift-bot · 2016-10-04T13:32:22Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9612/) (Image: devenv-rhel7_5128)

0xmichalis added the needs-api-review label Jun 15, 2016

deads2k reviewed Jun 15, 2016
View reviewed changes

0xmichalis changed the title ~~[WIP] Instantiate endpoint for deploymentconfigs~~ Instantiate endpoint for deploymentconfigs Jun 16, 2016

0xmichalis closed this Jun 20, 2016

0xmichalis reopened this Jun 20, 2016

This was referenced Jun 20, 2016

Deployment issues for 1.3 #9450

Closed

Trigger controller with caches #9485

Merged

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2016

0xmichalis mentioned this pull request Jun 24, 2016

deploy: fix initial image change deployments #9539

Merged

0xmichalis reviewed Jun 24, 2016
View reviewed changes

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 24, 2016

0xmichalis added this to the 1.3.0 milestone Jun 25, 2016

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2016

0xmichalis mentioned this pull request Jun 27, 2016

force a db deployment in extended template tests #9567

Merged

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2016

smarterclayton reviewed Jul 1, 2016
View reviewed changes

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2016

smarterclayton removed the needs-api-review label Sep 26, 2016

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 28, 2016

0xmichalis added 8 commits September 29, 2016 17:26

deploy: instantiate deploymentconfigs

9b47344

deploy: remove imagechange controller

f930946

oc: switch deploy --latest to use new instantiate endpoint

9acfba5

Run admission for /instantiate

e3d60f5

Make automatic=false work again as it should

04e3b17

This was a bad idea anyway and now we can provide users with 'oc rollout latest' which will manually do the resolving for them.

deploy: update generated code for instantiate

0c7b97a

deploy: generated protobuf for instantiate

d3caa5a

More generated code

2f86bfa

mfojtik added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2016

openshift-bot merged commit 6eafc1d into openshift:master Oct 4, 2016

0xmichalis deleted the instantiate-endpoint branch October 4, 2016 16:02

0xmichalis mentioned this pull request Nov 7, 2016

OpenShift 1.4/3.4 Release Notes Tracker openshift/openshift-docs#2933

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Instantiate endpoint for deploymentconfigs #9349

Instantiate endpoint for deploymentconfigs #9349

0xmichalis commented Jun 15, 2016 •

edited

Loading

0xmichalis commented Jun 15, 2016

deads2k Jun 15, 2016

0xmichalis commented Jun 16, 2016 •

edited

Loading

0xmichalis commented Jun 16, 2016

0xmichalis Jun 24, 2016

miminar Jun 24, 2016

smarterclayton Jun 24, 2016 via email

0xmichalis Jun 25, 2016

0xmichalis commented Jun 24, 2016

0xmichalis commented Jul 1, 2016

smarterclayton Jul 1, 2016

0xmichalis Jul 1, 2016

smarterclayton Jul 2, 2016

0xmichalis Jul 4, 2016

0xmichalis commented Jul 7, 2016

smarterclayton commented Sep 26, 2016

0xmichalis commented Sep 27, 2016

mfojtik commented Sep 27, 2016

deads2k commented Sep 27, 2016

0xmichalis commented Sep 27, 2016

0xmichalis commented Sep 27, 2016

smarterclayton commented Sep 28, 2016

openshift-bot commented Sep 29, 2016

openshift-bot commented Sep 29, 2016

0xmichalis commented Sep 29, 2016

0xmichalis commented Oct 3, 2016

mfojtik commented Oct 4, 2016

0xmichalis commented Oct 4, 2016

openshift-bot commented Oct 4, 2016

openshift-bot commented Oct 4, 2016 •

edited

Loading

Instantiate endpoint for deploymentconfigs #9349

Instantiate endpoint for deploymentconfigs #9349

Conversation

0xmichalis commented Jun 15, 2016 • edited Loading

0xmichalis commented Jun 15, 2016

Choose a reason for hiding this comment

0xmichalis commented Jun 16, 2016 • edited Loading

0xmichalis commented Jun 16, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smarterclayton Jun 24, 2016 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xmichalis commented Jun 24, 2016

0xmichalis commented Jul 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xmichalis commented Jul 7, 2016

smarterclayton commented Sep 26, 2016

0xmichalis commented Sep 27, 2016

mfojtik commented Sep 27, 2016

deads2k commented Sep 27, 2016

0xmichalis commented Sep 27, 2016

0xmichalis commented Sep 27, 2016

smarterclayton commented Sep 28, 2016

openshift-bot commented Sep 29, 2016

openshift-bot commented Sep 29, 2016

0xmichalis commented Sep 29, 2016

0xmichalis commented Oct 3, 2016

mfojtik commented Oct 4, 2016

0xmichalis commented Oct 4, 2016

openshift-bot commented Oct 4, 2016

openshift-bot commented Oct 4, 2016 • edited Loading

0xmichalis commented Jun 15, 2016 •

edited

Loading

0xmichalis commented Jun 16, 2016 •

edited

Loading

openshift-bot commented Oct 4, 2016 •

edited

Loading