Trigger controller with caches #9485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
| func (s *StoreToDeploymentConfigLister) GetConfigsForImageStream(stream *imageapi.ImageStream) ([]*deployapi.DeploymentConfig, error) { | ||
| var matching []*deployapi.DeploymentConfig | ||
| // TODO: Maybe build an index for object references | ||
| configs, err := s.List() |
There was a problem hiding this comment.
doing the List() blocks others from observing writes. Let's make that index.
|
lgtm, squash and wait for #9442 with the mutation checks before merging |
openshift-bot
added
the
needs-rebase
|
Evaluated for origin test up to befece1 |
openshift-bot
removed
the
needs-rebase
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5331/) |
|
[merge] |
|
flake: === BEGIN TEST CASE ===
test/cmd/admin.sh:247: executing 'oc create -f test/extended/testdata/roles/policy-clusterroles.yaml' expecting success
FAILURE after 0.742s: test/cmd/admin.sh:247: executing 'oc create -f test/extended/testdata/roles/policy-clusterroles.yaml' expecting success: the command returned the wrong error code
Standard output from the command:
clusterrole "basic-user2" created[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5359/) (Image: devenv-rhel7_4452) |
|
#9444, [merge] |
|
Evaluated for origin merge up to befece1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deads2k in a similar fashion to the main controller.
cc: @smarterclayton @ironcladlou @mfojtik