Create petset last in testdata #10236
Conversation
|
[test] |
|
@smarterclayton moves the petset creation to the end of the list so all the pod creates succeed |
|
also removes the allocated IP addresses from service data to avoid "already allocated" errors during test data creation |
|
We used to depend on the portal IP to verify it was properly shown by the describer. Is there still one spot that verifies it? |
|
PetSet changes look fine |
| template: | ||
| metadata: | ||
| annotations: | ||
| pod.alpha.kubernetes.io/init-containers: '[{"name":"install","image":"gcr.io/google_containers/galera-install:0.1","args":["--work-dir=/work-dir"],"resources":{},"volumeMounts":[{"name":"workdir","mountPath":"/work-dir"},{"name":"config","mountPath":"/etc/mysql"}],"terminationMessagePath":"/dev/termination-log","imagePullPolicy":"Always"},{"name":"bootstrap","image":"debian:jessie","command":["/work-dir/peer-finder"],"args":["-on-start=\"/work-dir/on-start.sh\"","-service=galera"],"env":[{"name":"POD_NAMESPACE","valueFrom":{"fieldRef":{"apiVersion":"v1","fieldPath":"metadata.namespace"}}}],"resources":{},"volumeMounts":[{"name":"workdir","mountPath":"/work-dir"},{"name":"config","mountPath":"/etc/mysql"}],"terminationMessagePath":"/dev/termination-log","imagePullPolicy":"IfNotPresent"}]' |
There was a problem hiding this comment.
Break the [{...}] string into lines. E.g. https://github.com/kubernetes/contrib/blob/master/pets/zookeeper/zookeeper.yaml#L35
There was a problem hiding this comment.
no, this is a straight move
There was a problem hiding this comment.
|
portalIP gets populated when creating the services |
|
But we're not testing it shows up in the right place unless we know what it is.
|
|
hmm, yeah, looks like tests depend on those IPs. will split that out to get the petset fix in |
|
[merge] |
|
Evaluated for origin test up to 7926fa3 |
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 3 |
|
Evaluated for origin merge up to 7926fa3 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7555/) |
|
green test run, merging to unblock queue |
|
woot |
petset test data is creating a petset, then creating all the pods that would result from the petset. The create races the petset controller (if it is running) and means that pod creations are likely to fail. Moving the petset to the end of the list ensures the pods get created by the test before the petset controller gets involved.
Also removes hardcoded IP addresses from services in testdata, since they can conflict with already allocated IPs when run on a live cluster
Fixes #10008