Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggest specifying flags before resource name #10772

Merged
merged 1 commit into from
Sep 27, 2016
Merged

suggest specifying flags before resource name #10772

merged 1 commit into from
Sep 27, 2016

Conversation

juanvallejo
Copy link
Contributor

@juanvallejo juanvallejo commented Sep 1, 2016 •
edited
Loading

Addresses comment #10770 (comment) in #10770

oc rsh <resource> treats everything to the right of <resource> a
command to execute inside a pod container. This patch updates the usage
output to clarify that flags for this command may be passed before the
resource name.

cc @openshift/cli-review

@juanvallejo
suggest specifying flags before resource name
fab0d0a 
`oc rsh <resource>` treats everything to the right of `<resource>` a
command to execute inside a pod container. This patch updates the usage
output to clarify that flags for this command may be passed before the
resource name.
@fabianofranz
Copy link
Member

LGTM, good to merge. @liggitt for approval.

@liggitt
Copy link
Contributor

liggitt commented Sep 1, 2016

not a blocker, so post-1.3

@fabianofranz
Copy link
Member

[merge]

@juanvallejo
Copy link
Contributor Author

juanvallejo commented Sep 20, 2016 •
edited
Loading

conformance test flaked on #11015 re[test]

@fabianofranz
Copy link
Member

flaked on #11015
re[merge]

@juanvallejo
Copy link
Contributor Author

merge conformance test flaked on #10951 re[test]

@juanvallejo
Copy link
Contributor Author

conformance test flaked on #9548 re[test]

@juanvallejo
Copy link
Contributor Author

conformance test flaked on #9548 re[test]

@juanvallejo
Copy link
Contributor Author

integration test flaked on #11058 re[test]

@fabianofranz
Copy link
Member

re[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 26, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9344/) (Image: devenv-rhel7_5084)

@juanvallejo
Copy link
Contributor Author

juanvallejo commented Sep 26, 2016 •
edited
Loading

conformance test flaked on #11079
integration test flaked on #11058
re[test]

@juanvallejo
Copy link
Contributor Author

conformance test flaked on #9548 re[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to fab0d0a

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9344/)

@fabianofranz
Copy link
Member

re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to fab0d0a

@openshift-bot openshift-bot merged commit 129c66c into openshift:master Sep 27, 2016
@juanvallejo juanvallejo deleted the jvallejo_oc-rsh-suggest-flags-before-resource-name branch September 27, 2016 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juanvallejo @fabianofranz @liggitt @openshift-bot