Made hello-openshift read the message from an environment variable

[knobunc]

This is a minor enhancement to the hello-openshift image to optionally
read the response string from the RESPONSE environment variable.

[knobunc]

@bparees PTAL

[bparees]

Lgtm

[smarterclayton]

It's better to use the deployment images for some of this (if you need to add features beyond this).

[knobunc]

@smarterclayton I just wanted a way to have multiple pods back a service and know which I am hitting. I've hit this a few times, so figured that it was not unreasonable to add.

[knobunc]

@smarterclayton I just wanted a way to have multiple pods back a service and know which I am hitting. I've hit this a few times, so figured that it was not unreasonable to add.

[smarterclayton]

[merge]

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to 45b12df

[openshift-bot]

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8962/)

[bparees]

flake #10951
[merge]

[bparees]

flake #10951
flake #10987
[merge]

[knobunc]

flake #10951
flake #10987
[merge] again

[bparees]

flake #9379
[merge]

[bparees]

flake #11006
flake #9379
[merge]

[bparees]

flake #10951
[merge]

@Kargakis @mfojtik these deployment flakes are really bad.

[mfojtik]

@bparees it really is a docker flake (deployer pod failed to start)

[bparees]

@mfojtik then why aren't we seeing it for build pods failing to start?

[bparees]

@mfojtik or application pods?

[bparees]

[merge]

On Tue, Sep 20, 2016 at 5:27 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9027/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10894 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3lPdFo6clT7xyUwAm9Z7CQAcsfYwks5qr_tkgaJpZM4J8G-h
.

Ben Parees | OpenShift

[0xmichalis]

@mfojtik then why aren't we seeing it for build pods failing to start?

What timeouts do you use in extended tests for build pods? A quick look shows you use 2min. We have stricter timeouts for deployments.

#10951 uses a 20s timeout
#11008 is not using a timeout
#10989 is not using a timeout (although this looks fishy because we are already using a timeout for the deployment to complete but we aren't actually waiting?)

We should probably increase those timeouts but by now, I think it's obvious that there is no deployment failure involved, it's just the deployer pod pending. And there is nothing special about the deployer pod.

[smarterclayton]

[merge]

On Tue, Sep 20, 2016 at 2:12 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9039/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10894 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p2xaFtLKxlLJRF4QWKf0Sb0NGFsTks5qsCIbgaJpZM4J8G-h
.

[bparees]

[merge]

On Tue, Sep 20, 2016 at 10:22 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9044/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10894 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvl3jzMmT4hI-mK8IV1mM6RH8_dO9_cks5qsECYgaJpZM4J8G-h
.

Ben Parees | OpenShift

[bparees]

flake #11016
[merge]

[bparees]

[merge]

[knobunc]

[merge]

[bparees]

[merge]

[openshift-bot]

Evaluated for origin merge up to 45b12df

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9133/) (Image: devenv-rhel7_5058)