Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove update percent #11090

Merged
merged 2 commits into from
Sep 29, 2016
Merged

Remove update percent #11090

merged 2 commits into from
Sep 29, 2016

Conversation

0xmichalis
Copy link
Contributor

@mfojtik @smarterclayton removes updatePercent which we were supposed to remove in 1.1 with a slight implication - oadm router from old clients will create routers with 25%-25% instead of 0-25% in new servers.

See https://bugzilla.redhat.com/show_bug.cgi?id=1378587 for more info.

@0xmichalis
Copy link
Contributor Author

[test]

@mfojtik
Copy link
Contributor

mfojtik commented Sep 26, 2016

LGTM

@0xmichalis
Copy link
Contributor Author

cc: @openshift/api-review

@smarterclayton
Copy link
Contributor

Please add a write up to the 1.4 deprecation notices (UPGRADES.md) and add it to the 1.4 release notes.

@smarterclayton
Copy link
Contributor

Removal is approved.

@mfojtik
Copy link
Contributor

mfojtik commented Sep 26, 2016

image

@0xmichalis
Copy link
Contributor Author

updated UPGRADE.md [merge]

@smarterclayton not sure what release notes are you talking about? Should I just Edit release for https://github.com/openshift/origin/releases/tag/v1.4.0-alpha.0 and add it there or are these notes in a different place?

@smarterclayton
Copy link
Contributor

Create an openshift-docs bug that says 1.4.0 release notes and add a
comment on there that includes this change (basically like we did for 1.3)

On Mon, Sep 26, 2016 at 11:28 AM, Michail Kargakis <notifications@github.com

wrote:

updated UPGRADE.md [merge]

@smarterclayton https://github.com/smarterclayton not sure what release
notes are you talking about? Should I just Edit release for
https://github.com/openshift/origin/releases/tag/v1.4.0-alpha.0 and add
it there or are these notes in a different place?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11090 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p-2tr2xV6kdYz3DibLUoG8BCjo5gks5qt-SMgaJpZM4KGSwm
.

@0xmichalis
Copy link
Contributor Author

Done: openshift/openshift-docs#2933

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2016
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2016
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 0601a7d

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9476/)

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 29, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9476/) (Image: devenv-rhel7_5101)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 0601a7d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants