-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favor --show-token over --token for whoami #11150
Favor --show-token over --token for whoami #11150
Conversation
@deads2k @smarterclayton @fabianofranz will open a doc PR to sweep in favor of the short flags if this meets with approval |
I really hope no one has baked this into their CI flows. |
[test] |
Evaluated for origin test up to 2587916 |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9466/) |
I'm strongly in favor of this, even though it will be breaking. |
Because -t is common use I'm ok with redefining "--token" but leaving "-t" unchanged. |
sounds good. this PR hides and marks as deprecated |
Evaluated for origin merge up to 2587916 |
One more use case for my idea of boolean kinda string flag type. :)
|
@openshift/cli-review |
Needs release notes. |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9528/) (Image: devenv-rhel7_5103) |
I badly want to be able to do
oc whoami --token=<some-token>
, but we made that the long form ofoc whoami -t
instead.Deprecate --token and --context in favor of --show-token and --show-context, so in a release we can switch back to using those for building the client