Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favor --show-token over --token for whoami #11150

Merged
merged 1 commit into from
Sep 30, 2016
Merged

Favor --show-token over --token for whoami #11150

merged 1 commit into from
Sep 30, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Sep 29, 2016

I badly want to be able to do oc whoami --token=<some-token>, but we made that the long form of oc whoami -t instead.

Deprecate --token and --context in favor of --show-token and --show-context, so in a release we can switch back to using those for building the client

@liggitt
Copy link
Contributor Author

liggitt commented Sep 29, 2016

@deads2k @smarterclayton @fabianofranz

will open a doc PR to sweep in favor of the short flags if this meets with approval

@smarterclayton
Copy link
Contributor

I really hope no one has baked this into their CI flows.

@liggitt
Copy link
Contributor Author

liggitt commented Sep 29, 2016

[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 2587916

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9466/)

@deads2k
Copy link
Contributor

deads2k commented Sep 29, 2016

I'm strongly in favor of this, even though it will be breaking.

@smarterclayton
Copy link
Contributor

Because -t is common use I'm ok with redefining "--token" but leaving "-t" unchanged.

@liggitt
Copy link
Contributor Author

liggitt commented Sep 29, 2016

sounds good. this PR hides and marks as deprecated --token and --context. I'll queue up removing the overridden behavior in 1.5
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 2587916

@fabianofranz
Copy link
Member

One more use case for my idea of boolean kinda string flag type. :)

--token
--token=<some-token>

@fabianofranz
Copy link
Member

@openshift/cli-review

@fabianofranz
Copy link
Member

Needs release notes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Sep 30, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9528/) (Image: devenv-rhel7_5103)

@openshift-bot openshift-bot merged commit 25aad16 into openshift:master Sep 30, 2016
@liggitt liggitt deleted the deprecate-whoami-token branch October 3, 2016 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants