Support specifying StorageClass while creating volumes #11451
Conversation
gnufied
force-pushed
the
support-claim-class-volume
branch
from
feb73d0
to
3965aba
Compare
Add support for specifying StorageClass when user is creating volumes via oc set volume command
gnufied
force-pushed
the
support-claim-class-volume
branch
from
3965aba
to
4a63ef2
Compare
|
[test] |
Also reword the documentation help
| @@ -52,6 +52,10 @@ For descriptions on other volume types, see | |||
| select all resources in the namespace of the specified resource types | |||
|
|
|||
| .PP | |||
| \fB\-\-claim\-class\fP="" | |||
| StorageClass to use for provisioning the persistent volume. | |||
There was a problem hiding this comment.
Remove all references to 'provisioning' in help string since not all storageClass is provisioned. Replace with something like 'StorageClass to use for the persistent volume claim'.
| @@ -52,6 +52,10 @@ For descriptions on other volume types, see | |||
| select all resources in the namespace of the specified resource types | |||
|
|
|||
| .PP | |||
| \fB\-\-claim\-class\fP="" | |||
| StorageClass to use for provisioning the persistent volume. | |||
There was a problem hiding this comment.
Replace with something like 'StorageClass to use for the persistent volume claim'.
| @@ -26,6 +26,10 @@ DEPRECATED: This command has been moved to "openshift cli set volume" | |||
| select all resources in the namespace of the specified resource types | |||
|
|
|||
| .PP | |||
| \fB\-\-claim\-class\fP="" | |||
| StorageClass to use for provisioning the persistent volume. | |||
There was a problem hiding this comment.
Replace with something like 'StorageClass to use for the persistent volume claim'.
| @@ -186,6 +190,7 @@ func NewCmdVolume(fullName string, f *clientcmd.Factory, out, errOut io.Writer) | |||
| cmd.Flags().StringVar(&addOpts.ConfigMapName, "configmap-name", "", "Name of the persisted config map. Must be provided for configmap volume type") | |||
| cmd.Flags().StringVar(&addOpts.SecretName, "secret-name", "", "Name of the persisted secret. Must be provided for secret volume type") | |||
| cmd.Flags().StringVar(&addOpts.ClaimName, "claim-name", "", "Persistent volume claim name. Must be provided for persistentVolumeClaim volume type") | |||
| cmd.Flags().StringVar(&addOpts.ClaimClass, "claim-class", "", "StorageClass to use for provisioning the persistent volume.") | |||
There was a problem hiding this comment.
Replace with something like 'StorageClass to use for the persistent volume claim'.
| @@ -26,6 +26,10 @@ DEPRECATED: This command has been moved to "oc set volume" | |||
| select all resources in the namespace of the specified resource types | |||
|
|
|||
| .PP | |||
| \fB\-\-claim\-class\fP="" | |||
| StorageClass to use for provisioning the persistent volume. | |||
There was a problem hiding this comment.
Replace with something like 'StorageClass to use for the persistent volume claim'.
gnufied
force-pushed
the
support-claim-class-volume
branch
from
52ebf8d
to
cd3f8a8
Compare
|
@childsb done. PTAL |
|
Evaluated for origin test up to cd3f8a8 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10313/) (Base Commit: 9ef2b7f) |
|
It seems to have flaked on #11024 |
|
claim-mode -> access-mode? |
|
claim-mode is already in oc volume, changes would break existing setups. We could create a |
|
What does How about the access mode? The SC? |
|
In first case - user's input is rejected outright and she gets following error: How about Access mode? The values are not overwritten unless user explicitly uses |
|
[merge] |
|
[merge] #11114 |
|
Evaluated for origin merge up to cd3f8a8 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10470/) (Base Commit: fe6bff4) (Image: devenv-rhel7_5226) |
Add support for specifying StorageClass when user is creating
volumes via oc set volume command