deploy: drop unnecessary resource handlers to reduce dc requeues #11805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No reason to enqueue deployment configs on rc ADDs since there is no new info deployment configs don't know at that point (adoption is not possible). No reason to enqueue on pod ADDs since the only reasons we need pod notification are 1) to bring back DELETEd pods and 2) to update the deployment config status with AvailableReplicas once a pod is UPDATEd to Ready/Available.
|
[test] |
|
Can somebody from @openshift/team-origin-committers rekick Jenkins? |
|
Evaluated for origin test up to 5109853 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11933/) (Base Commit: 1023112) |
|
LGTM since adoption is not possible. [merge] |
|
flake is #12157 |
|
[merge] |
|
#12184 [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11933/) (Image: devenv-rhel7_5515) |
|
#8571 [merge] |
|
Evaluated for origin merge up to 5109853 |
ncdc
pushed a commit
to ncdc/origin
that referenced
this pull request
Dec 23, 2016
ncdc
pushed a commit
to ncdc/origin
that referenced
this pull request
Jan 3, 2017
ncdc
pushed a commit
to ncdc/origin
that referenced
this pull request
Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to enqueue deployment configs on rc ADDs since there is no
new info deployment configs don't know at that point (adoption is not
possible). No reason to enqueue on pod ADDs since the only reasons we
need pod notification are 1) to bring back DELETEd pods and 2) to
update the deployment config status with AvailableReplicas once a pod
is UPDATEd to Ready/Available.
cc: @mfojtik @smarterclayton
[test]