resolve logic errors introduced in #11077 and return 40x errors instead of 500 errors where possible #11810
Conversation
|
@jim-minter i'm failing to see how this addresses the missing branch behavior in the referenced issue? |
| case webhook.MethodNotSupported: | ||
| return errors.NewMethodNotSupported(buildapi.Resource("buildconfighook"), req.Method) | ||
| } | ||
| if _, ok := err.(*errors.StatusError); !ok { |
There was a problem hiding this comment.
is the branch issue resolved by getting rid of the "default" from the switch?
There was a problem hiding this comment.
yes, and then passing err through untouched if it is of type *errors.StatusError.
|
[merge] |
|
[Test]ing while waiting on the merge queue |
|
…ors instead of 500 errors where possible
jim-minter
force-pushed
the
issue11736
branch
from
5968f11
to
6243982
Compare
|
Sorry, one missing err != nil check. |
|
[merge] |
|
looks like network flakes. |
|
flake #9886 |
|
flake #10773 |
|
[merge] Ben Parees | OpenShift On Nov 9, 2016 6:37 PM, "OpenShift Bot" notifications@github.com wrote:
|
|
flake #10773 |
|
[test] |
|
Evaluated for origin test up to 6243982 |
|
Evaluated for origin merge up to 6243982 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11346/) (Base Commit: 43fbf69) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11346/) (Base Commit: ee5a124) (Image: devenv-rhel7_5347) |
|
flake #9076 again |
|
well that has to be some sort of record. |
fixes #11736