Fixes failing router integration test #12783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sition Deleted -> Added instead of Modified -> Added. Otherwise the event queue code panics and kills the cache reflector goroutine which causes events to never be delivered to the test router process. fixes openshift#12736
|
[test] |
|
Evaluated for origin test up to 0ed96c6 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13540/) (Base Commit: 89ed457) |
|
LGTM [merge] |
|
Evaluated for origin merge up to 0ed96c6 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13554/) (Base Commit: 97275c6) (Image: devenv-rhel7_5845) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failing router integration tests - use watch.Deleted event on the endpoints to ensure we do a valid transition Deleted -> Added instead of Modified -> Added for the events we are simulating in
the test code.
Otherwise the event queue code panics and kills the cache reflector
goroutine which causes events to never be delivered to the test router process.
fixes #12736
Associated error in the logs was
There is a the panic is logged in
https://github.com/openshift/origin/blob/master/pkg/client/cache/eventqueue.go#L132
which causes the cache.NewReflector goroutine (in
pkg/router/controller/factory/factory.go) to die off and no events get delivered in the tests causing failures further down the road.fixes #12736
@knobunc PTAL Thx