improve oc set volume --override flag description
#12838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanvallejo
force-pushed
the
jvallejo/improve-override-flag-description
branch
from
33df6e6
to
325e686
Compare
|
[test] |
pkg/cmd/cli/cmd/set/volume.go
Outdated
| @@ -187,7 +187,7 @@ func NewCmdVolume(fullName string, f *clientcmd.Factory, out, errOut io.Writer) | |||
| cmd.Flags().StringVarP(&addOpts.Type, "type", "t", "", "Type of the volume source for add operation. Supported options: emptyDir, hostPath, secret, configmap, persistentVolumeClaim") | |||
| cmd.Flags().StringVarP(&addOpts.MountPath, "mount-path", "m", "", "Mount path inside the container. Optional param for --add or --remove") | |||
| cmd.Flags().StringVarP(&addOpts.DefaultMode, "default-mode", "", "", "The default mode bits to create files with. Can be between 0000 and 0777. Defaults to 0644.") | |||
| cmd.Flags().BoolVar(&addOpts.Overwrite, "overwrite", false, "If true, replace existing volume source and/or volume mount for the given resource") | |||
| cmd.Flags().BoolVar(&addOpts.Overwrite, "overwrite", false, "If true, replace existing volume source by the same name and/or volume mount for the given resource") | |||
There was a problem hiding this comment.
"by the same name" seems awkward - "by name" or "with the provided name"
juanvallejo
force-pushed
the
jvallejo/improve-override-flag-description
branch
2 times, most recently
from
636e475
to
bf7388d
Compare
|
@juanvallejo squash? |
juanvallejo
force-pushed
the
jvallejo/improve-override-flag-description
branch
from
bf7388d
to
4bcaf11
Compare
|
@fabianofranz |
|
LGTM [merge] |
|
check_future flaked on #12923 re[test] |
|
Evaluated for origin test up to 4bcaf11 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/319/) (Base Commit: e4300b3) |
|
flaked on #12923 re[merge] |
|
Evaluated for origin merge up to 4bcaf11 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/339/) (Base Commit: d90a085) (Image: devenv-rhel7_5938) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1319964
Adds a warning message if overriding a volume that did not previously exist, alerting the user that it has been created instead. Updates the existing flag description for
--override.cc @openshift/cli-review @smarterclayton @nak3