the router tests demand access to the 1936 port

[rajatchopra]

to fix issue #12784

[test]

[openshift-bot]

Evaluated for origin test up to 58912aa

[rajatchopra]

@marun This should be harmless right? Just wondering how were the router /healthz checks ever working without this.

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/406/) (Base Commit: 20682f2)

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/406/) (Base Commit: 20682f2)

[rajatchopra]

@ramr you have reviewed it, mark it formally please?

@bparees could we get a merge on this?

[bparees]

I'd like to make sure we understand why this ever works today before merging the change.

[ramr]

LGTM

[ramr]

@bparees in order for this test to succeed in isolation those 3 ports need to be open.
So from a specific test perspective - that's a requirement.

Now as re: in conjunction with other tests and it sometimes passing (we don't see anything in the logs to indicate it ran), it could be:

1. Either the test never ran - which means we have some test selection criteria am not aware off.
2. Or then for it to succeed, something else is "unblocking" iptables. Because by default, the rules
   block any ports other than 22 and 10250. See: https://github.com/openshift/origin/blob/master/images/dind/node/iptables#L12
   Supposition was the e2e tests but am not certain about that. See comments in Extended.[networking][router] openshift routers The HAProxy router should serve the correct routes when scoped to a single namespace and label set #12784

[bparees]

[merge]

[bparees]

[merge]

[openshift-bot]

Evaluated for origin merge up to 58912aa

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_future/469/) (Base Commit: 80b2f6d) (Image: devenv-rhel7_5962)