Use shared informers in scheduler and token controller #14321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deads2k
reviewed
May 24, 2017
pkg/cmd/server/start/start_master.go
Outdated
| @@ -609,6 +609,9 @@ func startControllers(oc *origin.MasterConfig, kc *kubernetes.MasterConfig) erro | |||
| // Start these first, because they provide credentials for other controllers' clients | |||
| oc.RunServiceAccountsController() | |||
| oc.RunServiceAccountTokensController(controllerManagerOptions) | |||
| // Must start a few informers now | |||
| oc.Informers.KubernetesInformers().Start(utilwait.NeverStop) | |||
There was a problem hiding this comment.
These need to start to make the SA token controller active, right? Be more descriptive in your comment. Lots of people end up here.
There was a problem hiding this comment.
Yeah, will add more of a comment
smarterclayton
force-pushed
the
upstream_reuse
branch
from
7ff83d5
to
a8ba30b
Compare
|
Evaluated for origin test up to a8ba30b |
|
lgtm |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1695/) (Base Commit: 61b1f2a) |
|
[merge] for great performance |
|
Evaluated for origin merge up to a8ba30b |
|
continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/785/) (Base Commit: 4a682ba) |
|
[merge][severity: blocker] memory use is still p0 for 3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains upstream fixes and a few minor reaction changes. Rebase pick was a little ugly because of the number of changes, but verified it passed in upstream branch and downstream.
@deads2k @sttts [test]