-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1268000 - replace Image.DockerImageReference with value from status. #5495
Conversation
will this break the way we are using this field's value to correlate image streams with deployments in https://github.com/openshift/origin/blob/master/assets/app/scripts/services/imageStreamResolver.js#L58 cc @jwforres |
See my comment here: #5481 (comment) |
LGTM. #5481 (comment) seems covered to me. |
I don't see any more objections. |
[Test]ing while waiting on the merge queue |
I've rebased the PR, because the error:
completely doesn't make sense to me. It looked as if local merge failed along the way. |
Previous rebase for some reason didn't picked up the changes, this finally does. |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3892/) (Image: devenv-rhel7_2623) |
integration test failure, which I forgot about to check before :/ |
Evaluated for origin merge up to d94907e |
Evaluated for origin test up to d94907e |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6562/) |
Fixes #5481 and https://bugzilla.redhat.com/show_bug.cgi?id=1268000.
@miminar @ncdc ptal