extended: Allow to focus on particular tests #8438
Conversation
|
@stevekuznetsov could you please take one more look? |
| if [[ "${tests}" -eq 0 ]]; then | ||
| echo "[ERROR] No tests would be run" | ||
| exit 1 | ||
| fi | ||
| ${EXTENDEDTEST} "$@" | ||
| ${EXTENDEDTEST} "$*" |
There was a problem hiding this comment.
We can see the effect of $* etc with a simple script:
With args:
'one' 'two 2' 'three 3' '4' '5'
Using $*:
'one' 'two' '2' 'three' '3' '4' '5'
Using "$*":
'one two 2 three 3 4 5'
Using $@:
'one' 'two' '2' 'three' '3' '4' '5'
Using "$@":
'one' 'two 2' 'three 3' '4' '5'
I believe we want "$@" here, as well as above.
|
Fixed. |
|
Can you try a "testonlyextended"? Would be easier to look at the logs and verify things ran correctly |
|
Argh.. jenkins turns
|
|
How do I remove |
|
I believe if you delete all your comments containing test key words and keep only the last one. Let's investigate the Jenkins lower casing issue here too, as that's pretty integral to being able to specify tests correctly. |
|
Good idea!. Let's try again with previous test comments deleted. [testonlyextended][extended:core(result image should have proper labels)] |
|
Looks like it selected tests correctly. LGTM |
|
@pweil- may I humbly request your powerful merge super-powers? |
|
this is also called in |
Focus usually involves string with spaces such as:
./test/extended/core.sh --ginkgo.focus='quota admission' --ginkgo.failFast
Signed-off-by: Michal Minar <miminar@redhat.com>
|
@pweil- good catch! Updated. |
|
Evaluated for origin testonlyextended up to d2d9b96 |
|
continuous-integration/openshift-jenkins/testonlyextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/22/) (Extended Tests: core(result image should have proper labels)) |
|
LGTM |
|
@deads2k would you like to exercise your mighty merge skill? |
|
[merge] - test only |
|
Evaluated for origin merge up to d2d9b96 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to d2d9b96 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3009/) (Extended Tests: core(result image should have proper labels)) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3009/) (Image: devenv-rhel7_3983) |
Focus usually involves string with spaces such as:
Replaces #8420