Allow size of image to be zero when schema1 from Hub #9118
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DockerHub now converts schema2 image manifests pushed by Docker 1.10 or higher clients into schema1, but when it does that it drops all v1Compatibility objects except the top layer. When it does that it loses size info. Since we anticipate moving to schema2 soon, and the number of schema1 images should decline, adapt the tests to flag this error.
|
continuous-integration/openshift-jenkins/merge Waiting: You are in the build queue at position: 4 |
|
Evaluated for origin merge up to b30f322 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin test up to b30f322 |
|
I'm going to direct merge when tests pass. |
|
You forgot about |
|
It is not failing for me |
|
My mistake. Sorry. |
|
LGTM |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4307/) |
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DockerHub now converts schema2 image manifests pushed by Docker 1.10
or higher clients into schema1, but when it does that it drops all
v1Compatibility objects except the top layer. When it does that it
loses size info. Since we anticipate moving to schema2 soon, and the
number of schema1 images should decline, adapt the tests to flag this
error.
[merge]