-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary export #9511
remove unnecessary export #9511
Conversation
#5448 is being tagged incorrectly. |
[test] |
Changes mostly LGTM -- @deads2k is the etcd dump using Also, why should we prefer the |
Maybe that's not well known, I'll add it to the "maybe demo" list. |
Ah, yes I vaguely remember you implementing that now. Decision to remove this now much better understood. |
71b4ee1
to
b2a2d3b
Compare
rebased. still lgtm? |
Still LGTM |
LGTM [merge] |
👍 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7413/) (Image: devenv-rhel7_4730) |
Evaluated for origin merge up to b2a2d3b |
#9959 re[test] |
re[test] |
Flake: #9775 re-[merge] |
re[test] |
yum re[test] |
Evaluated for origin test up to b2a2d3b |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7390/) |
Found while inspecting a false error indication triggered on
Error from server: User "e2e-user" cannot list all buildconfigs in the cluster
. Given the etcd dump, this is an unnecessary export.