Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: add source for hook events #9892

Merged
merged 1 commit into from
Jul 20, 2016
Merged

deploy: add source for hook events #9892

merged 1 commit into from
Jul 20, 2016

Conversation

0xmichalis
Copy link
Contributor

@mfojtik PTAL

Previous output when describing a dc:

Events:
  FirstSeen LastSeen    Count   From                SubobjectPath   Type        Reason          Message
  --------- --------    -----   ----                -------------   --------    ------          -------
  1m        1m      1   { }                     Normal      Completed       The pre-hook for deployment test/database-2 completed successfully
  1m        1m      1   { }                     Normal      Started         Running mid-hook ("/bin/true") for deployment test/database-2
  1m        1m      1   { }                     Normal      Completed       The mid-hook for deployment test/database-2 completed successfully
  53s       53s     1   { }                     Normal      Started         Running post-hook ("/bin/false") for deployment test/database-2
  48s       48s     1   { }                     Warning     Failed          The post-hook failed:  (ignore), deployment test/database-2 will continue
  18s       18s     1   {deploymentconfig-controller }          Normal      DeploymentCreated   Created new deployment "database-3" for version 3
  15s       15s     1   { }                     Normal      Started         Running pre-hook ("/bin/foo") for deployment test/database-3
  9s        9s      1   { }                     Warning     Failed          The pre-hook failed: , aborting deployment test/database-3

Now:

Events:
  FirstSeen LastSeen    Count   From                SubobjectPath   Type        Reason          Message
  --------- --------    -----   ----                -------------   --------    ------          -------
  3m        3m      1   {deploymentconfig-controller }          Normal      DeploymentCreated   Created new deployment "database-1" for version 1
  3m        3m      1   {database-1-deploy }                Normal      Started         Running pre-hook ("/bin/true") for deployment default/database-1
  3m        3m      1   {database-1-deploy }                Normal      Started         Running mid-hook ("/bin/true") for deployment default/database-1
  3m        3m      1   {database-1-deploy }                Normal      Completed       The pre-hook for deployment default/database-1 completed successfully
  3m        3m      1   {database-1-deploy }                Normal      Completed       The mid-hook for deployment default/database-1 completed successfully
  3m        3m      1   {database-1-deploy }                Normal      Started         Running post-hook ("/bin/false") for deployment default/database-1
  3m        3m      1   {database-1-deploy }                Warning     Failed          The post-hook failed:  (ignore), deployment default/database-1 will continue

@mfojtik
Copy link
Contributor

mfojtik commented Jul 18, 2016

LGTM [merge]

@0xmichalis
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 95db36a

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6438/)

@0xmichalis
Copy link
Contributor Author

#9775 [merge]

@0xmichalis
Copy link
Contributor Author

#9938 [merge]

@0xmichalis
Copy link
Contributor Author

[merge] again

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 20, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/6614/) (Image: devenv-rhel7_4633)

@0xmichalis
Copy link
Contributor Author

#9845 [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 95db36a

@openshift-bot openshift-bot merged commit 9210b71 into openshift:master Jul 20, 2016
@0xmichalis 0xmichalis deleted the hook-events-source branch July 20, 2016 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants