OCM-7673 | fix: Provide the default value to the external auth

Signed-off-by: Maggie Chen <magchen@redhat.com> fix const Signed-off-by: Maggie Chen <magchen@redhat.com>
openshift · May 1, 2024 · 56e4b45 · 56e4b45
1 parent cd2d1ab
commit 56e4b45
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/externalauthprovider/flags.go b/pkg/externalauthprovider/flags.go
@@ -25,6 +25,8 @@ const (
 	claimValidationRuleFlag       = "claim-validation-rule"
 	consoleClientIdFlag           = "console-client-id"
 	consoleClientSecretFlag       = "console-client-secret"
+	defaultClaimMappingUsername   = "email"
+	defaultClaimMappingGroups     = "groups"
 )
 
 type ExternalAuthServiceImpl struct {
@@ -256,7 +258,7 @@ func GetExternalAuthOptions(
 	if interactive.Enabled() && !cmd.Changed(claimMappingUsernameClaimFlag) {
 		result.claimMappingUsernameClaim, err = interactive.GetString(interactive.Input{
 			Question: "Claim mapping username",
-			Default:  result.claimMappingUsernameClaim,
+			Default:  defaultClaimMappingUsername,
 			Help:     cmd.Lookup(claimMappingUsernameClaimFlag).Usage,
 			Required: true,
 		})
@@ -268,7 +270,7 @@ func GetExternalAuthOptions(
 	if interactive.Enabled() && !cmd.Changed(claimMappingGroupsClaimFlag) {
 		result.claimMappingGroupsClaim, err = interactive.GetString(interactive.Input{
 			Question: "Claim mapping groups",
-			Default:  result.claimMappingGroupsClaim,
+			Default:  defaultClaimMappingGroups,
 			Help:     cmd.Lookup(claimMappingGroupsClaimFlag).Usage,
 			Required: true,
 		})