Skip to content

Commit

Permalink
OCM-10298 | ci: fix id:73391,65160
Browse files Browse the repository at this point in the history
  • Loading branch information
aaraj7 committed Aug 9, 2024
1 parent 5f2df44 commit ea5ecc0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
4 changes: 0 additions & 4 deletions tests/e2e/test_rosacli_idp.go
Original file line number Diff line number Diff line change
Expand Up @@ -778,8 +778,6 @@ var _ = Describe("Edit IDP",
Expect(err).To(BeNil())
textData = rosaClient.Parser.TextData.Input(output).Parse().Tip()
Expect(textData).Should(ContainSubstring("Identity Provider '%s' has been created", idpNames[1]))
Expect(textData).Should(ContainSubstring("To log in to the console, open"))
Expect(textData).Should(ContainSubstring("and click on '%s'", idpNames[1]))

By("List IDPs")
idpTab, _, err := idpService.ListIDP(clusterID)
Expand Down Expand Up @@ -825,8 +823,6 @@ var _ = Describe("Edit IDP",
Expect(err).To(BeNil())
textData := rosaClient.Parser.TextData.Input(output).Parse().Tip()
Expect(textData).Should(ContainSubstring("Identity Provider '%s' has been created", idpNames[0]))
Expect(textData).Should(ContainSubstring("To log in to the console, open"))
Expect(textData).Should(ContainSubstring("and click on '%s'", idpNames[0]))

By("Create htpasswd idp with --users flag")
output, err = idpService.CreateIDP(clusterID, idpNames[1],
Expand Down
5 changes: 3 additions & 2 deletions tests/e2e/test_rosacli_node_pool.go
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,7 @@ var _ = Describe("Edit nodepool",
Expect(err).To(HaveOccurred())
Expect(rosaClient.Parser.TextData.Input(output).Parse().Tip()).
To(ContainSubstring(
"The number of machine pool replicas needs to be a non-negative integer"))
"ERR: Failed to get autoscaling or replicas: 'Replicas must be a non-negative number'"))

By("Try to edit the machinepool with --min-replicas flag when autoscaling is disabled for the machinepool.")
output, err = machinePoolService.EditMachinePool(clusterID, machinepoolName, "--min-replicas", "2")
Expand Down Expand Up @@ -986,7 +986,8 @@ var _ = Describe("Edit nodepool",
Expect(err).To(HaveOccurred())
Expect(rosaClient.Parser.TextData.Input(output).Parse().Tip()).
To(ContainSubstring(
"The number of machine pool min-replicas needs to be greater than zero"))
"ERR: Failed to get autoscaling or replicas: " +
"'Min replicas must be a non-negative number when autoscaling is set'"))

By("Try to edit machinepool with --replicas flag when the autoscaling is enabled for the machinepool.")
output, err = machinePoolService.EditMachinePool(clusterID, machinepoolName, "--replicas", "3")
Expand Down

0 comments on commit ea5ecc0

Please sign in to comment.