-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6314 | ci: Refactor day1 creation function for test #1861
Conversation
ef230c1
to
2ad0ae1
Compare
96fd527
to
fae78fe
Compare
7aa5712
to
c1ff6d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1861 +/- ##
=======================================
Coverage 21.69% 21.69%
=======================================
Files 118 118
Lines 19782 19782
=======================================
Hits 4292 4292
Misses 15165 15165
Partials 325 325 ☔ View full report in Codecov by Sentry. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot of helpers and such do we plan to cover these with Unit Tests?
Overall looks good to me, left some nitpicks inline.
@ciaranRoche Comments updated and resolved. Do you mind to review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments. otherwise lgtm
f1ea8a8
to
483c117
Compare
Fix comments Fix comment Remove the redunant func OCM-6314 | ci: Refactor day1 creation function for test Fix name prefix cannot be set issue
/lgtm |
@xueli181114: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, radtriste, xueli181114, yingzhanredhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, radtriste, xueli181114, yingzhanredhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is used to track the day1 function refactor for automation test