Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-6199 | ci: fix can not find go.mod #1942

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

yasun1
Copy link
Contributor

@yasun1 yasun1 commented Apr 18, 2024

As we migrated Dockerfile from the repository release to rosa, on Prow CI, we will use docker_path instead of docker_literal(openshift/release#50960). The docker_path method requires uploading the repository source code from the build context into an image layer.

Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

@yasun1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.42%. Comparing base (2f4f852) to head (5abc4e0).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1942      +/-   ##
==========================================
+ Coverage   21.71%   22.42%   +0.70%     
==========================================
  Files         118      126       +8     
  Lines       19809    20105     +296     
==========================================
+ Hits         4302     4508     +206     
- Misses      15186    15249      +63     
- Partials      321      348      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yasun1
Copy link
Contributor Author

yasun1 commented Apr 18, 2024

@ciaranRoche Please help review the PR. Thanks.

1 similar comment
@yasun1
Copy link
Contributor Author

yasun1 commented Apr 18, 2024

@ciaranRoche Please help review the PR. Thanks.

Copy link
Member

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
Copy link
Contributor

openshift-ci bot commented Apr 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, yasun1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2cb9184 into openshift:master Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants