-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-6199 | ci: fix can not find go.mod #1942
OCM-6199 | ci: fix can not find go.mod #1942
Conversation
@yasun1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1942 +/- ##
==========================================
+ Coverage 21.71% 22.42% +0.70%
==========================================
Files 118 126 +8
Lines 19809 20105 +296
==========================================
+ Hits 4302 4508 +206
- Misses 15186 15249 +63
- Partials 321 348 +27 ☔ View full report in Codecov by Sentry. |
@ciaranRoche Please help review the PR. Thanks. |
1 similar comment
@ciaranRoche Please help review the PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, yasun1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As we migrated Dockerfile from the repository release to rosa, on Prow CI, we will use docker_path instead of docker_literal(openshift/release#50960). The docker_path method requires uploading the repository source code from the build context into an image layer.