-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-7795 | fix: update aws sdk to fix imds v2 issue #1979
Conversation
/cherry-pick release_1.2.39 |
@ciaranRoche: once the present PR merges, I will cherry-pick it on top of release_1.2.39 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test test |
/retest-required |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1979 +/- ##
==========================================
+ Coverage 23.56% 23.72% +0.15%
==========================================
Files 138 138
Lines 21333 21412 +79
==========================================
+ Hits 5027 5079 +52
- Misses 15931 15952 +21
- Partials 375 381 +6 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciaranRoche, davidleerh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test coverage |
@ciaranRoche: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Cherry pick created multiple merge conflicts; therefore, copied the "go.mod" from master to release branch and re-ran go mod tidy / go mod vendor. |
WHAT
Issue in AWS SDK resulted in not being able to resolve the IMDS role.
This change bumps the SDK to latest versions
Verification
When running CLI with latest 1.2.38 version
When running CLI from a build in this PR
JIRA - https://issues.redhat.com/browse/OCM-7795