Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7795 | fix: update aws sdk to fix imds v2 issue #1979

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ciaranRoche
Copy link
Member

@ciaranRoche ciaranRoche commented Apr 30, 2024

WHAT
Issue in AWS SDK resulted in not being able to resolve the IMDS role.

This change bumps the SDK to latest versions

Verification
When running CLI with latest 1.2.38 version

[ec2-user@ip-10-0-101-205 ~]$ ./rosa list clusters
E: Failed to create AWS client: operation error STS: GetCallerIdentity, get identity: get credentials: failed to refresh cached credentials, no EC2 IMDS role found, not found, Signing

When running CLI from a build in this PR

[ec2-user@ip-10-0-101-205 ~]$ ./rosa-linux-amd64 list clusters
ID                                NAME            STATE  TOPOLOGY
1u42ijpktv18lobegtb6min5m5gscgb7  testovn1        ready  Classic (STS)
20agiuq3dmuu7oer2hiedhpqq0p4st5q  isaac-cluster   error  Classic (STS)
241vjd270226ss167ir9ulcvbh7nkcqg  osilkin-test-1  error  Classic
2agqoqjhac8j67d3b4imha7m208978dt  dmoskale        ready  Classic (STS)

JIRA - https://issues.redhat.com/browse/OCM-7795

@ciaranRoche
Copy link
Member Author

/cherry-pick release_1.2.39

@openshift-cherrypick-robot

@ciaranRoche: once the present PR merges, I will cherry-pick it on top of release_1.2.39 in a new PR and assign it to you.

In response to this:

/cherry-pick release_1.2.39

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@davidleerh
Copy link
Contributor

/test test

@ciaranRoche
Copy link
Member Author

/retest-required

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.72%. Comparing base (09ec783) to head (4b34704).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1979      +/-   ##
==========================================
+ Coverage   23.56%   23.72%   +0.15%     
==========================================
  Files         138      138              
  Lines       21333    21412      +79     
==========================================
+ Hits         5027     5079      +52     
- Misses      15931    15952      +21     
- Partials      375      381       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidleerh
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciaranRoche, davidleerh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ciaranRoche,davidleerh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ciaranRoche
Copy link
Member Author

/test coverage

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@ciaranRoche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 91d7691 into openshift:master Apr 30, 2024
12 checks passed
@davidleerh
Copy link
Contributor

Cherry pick created multiple merge conflicts; therefore, copied the "go.mod" from master to release branch and re-ran go mod tidy / go mod vendor.
8d35bed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants