-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCM-8257 | ci: Split creation out and split cluster waiting out and make autoscaler value to 10 #2096
Conversation
…ake autoscaler value to 10
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
+ Coverage 26.41% 26.58% +0.17%
==========================================
Files 150 152 +2
Lines 21361 21787 +426
==========================================
+ Hits 5642 5792 +150
- Misses 15295 15572 +277
+ Partials 424 423 -1 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xueli181114, yuwang-RH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xueli181114: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What I did in the PR
When set
WAIT_SETUP_CLUSTER_READY=false
then the cluster preparation will only create the cluster and exit without waiting for cluster ready.If want to wait for cluster ready after cluster is prepared run command
ginkgo -focus WaitClusterReady tests/e2e
I split out the resources recording, so any resources need to be pass to destroy step will be recorded once created. It will make the risk of resource leak to the lowest for destroy