Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-8257 | ci: Split creation out and split cluster waiting out and make autoscaler value to 10 #2096

Merged
merged 1 commit into from
May 27, 2024

Conversation

xueli181114
Copy link
Contributor

What I did in the PR
When set WAIT_SETUP_CLUSTER_READY=false then the cluster preparation will only create the cluster and exit without waiting for cluster ready.
If want to wait for cluster ready after cluster is prepared run command ginkgo -focus WaitClusterReady tests/e2e
I split out the resources recording, so any resources need to be pass to destroy step will be recorded once created. It will make the risk of resource leak to the lowest for destroy

@openshift-ci openshift-ci bot requested review from radtriste and yasun1 May 23, 2024 15:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.58%. Comparing base (5d01073) to head (4c1ccbb).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
+ Coverage   26.41%   26.58%   +0.17%     
==========================================
  Files         150      152       +2     
  Lines       21361    21787     +426     
==========================================
+ Hits         5642     5792     +150     
- Misses      15295    15572     +277     
+ Partials      424      423       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xueli181114
Copy link
Contributor Author

xueli181114 commented May 23, 2024

lixue@Xue-Lis-MacBook-Pro rosa % ginkgo run -label-filter day1-prepare tests/e2e
Running Suite: e2e tests suite - /Users/lixue/Workspace/rosa/tests/e2e
======================================================================
Random Seed: 1716478309

Will run 1 of 80 specs
SSSSSSSSSSSSSSSStime="2024-05-23 23:35:25" level=info msg="Going to prepare a vpc with name xueli-g3ljblgwe, on region us-east-1, with cidr 10.0.0.0/16 "
time="2024-05-23 23:35:26" level=info msg="Going to create vpc and the follow resources on zones: "
time="2024-05-23 23:35:28" level=info msg="Create vpc success vpc-0d0a597b147ae95db"
time="2024-05-23 23:35:28" level=info msg="Tag resource vpc-0d0a597b147ae95db successfully"
time="2024-05-23 23:35:28" level=info msg="Created vpc with ID vpc-0d0a597b147ae95db"
time="2024-05-23 23:35:28" level=info msg="VPC created on AWS with id: vpc-0d0a597b147ae95db"
time="2024-05-23 23:35:29" level=info msg="Modify vpc dns attribute DnsHostnames successfully for vpc-0d0a597b147ae95db"
time="2024-05-23 23:35:29" level=info msg="VPC DNS Updated on AWS with id: vpc-0d0a597b147ae95db"
time="2024-05-23 23:35:29" level=info msg="Create igw success: igw-09db571c4930261df"
time="2024-05-23 23:35:30" level=info msg="Attach igw success: igw-09db571c4930261df"
time="2024-05-23 23:35:30" level=info msg="Prepare vpc internetgateway for vpc vpc-0d0a597b147ae95db"
time="2024-05-23 23:35:30" level=info msg="Create subnets successfully"
time="2024-05-23 23:35:30" level=info msg="Create vpc chain successfully. Enjoy it."
time="2024-05-23 23:35:30" level=info msg="Going to prepare proper pair of subnets"
time="2024-05-23 23:35:30" level=info msg="Got no public subnet for current zone us-east-1a, going to create one"
time="2024-05-23 23:35:30" level=info msg="Created subnet subnet-03e973be1484abecd for vpc vpc-0d0a597b147ae95db"
time="2024-05-23 23:35:31" level=info msg="Created subnet with ID subnet-03e973be1484abecd"
time="2024-05-23 23:35:32" level=info msg="Associate route table success rtbassoc-0cd1d3acfe9ae6c81"
time="2024-05-23 23:35:33" level=info msg="Create route success for route table: rtb-08ee326f7a454ff1f"
time="2024-05-23 23:35:33" level=info msg="Tag resource subnet-03e973be1484abecd successfully"
time="2024-05-23 23:35:33" level=info msg="Got no proper private subnet for current zone us-east-1a, going to create one"
time="2024-05-23 23:35:35" level=info msg="Created subnet subnet-0247dd6909aae1d5e for vpc vpc-0d0a597b147ae95db"
time="2024-05-23 23:35:35" level=info msg="Created subnet with ID subnet-0247dd6909aae1d5e"
time="2024-05-23 23:35:36" level=info msg="Associate route table success rtbassoc-0e37f22b7ea7dbfad"
time="2024-05-23 23:35:36" level=info msg="Allocated EIP eipalloc-0d1760b877e09d08b with ip 34.232.137.56"
time="2024-05-23 23:35:37" level=info msg="Create nat success: nat-009f045d48b1d56c8"
time="2024-05-23 23:37:17" level=info msg="Create route success for route table: rtb-09b4fce007af5fced"
time="2024-05-23 23:37:17" level=info msg="Tag resource subnet-0247dd6909aae1d5e successfully"
time="2024-05-23 23:37:17" level=info msg="Going to prepare proper pair of subnets"
time="2024-05-23 23:37:17" level=info msg="Subnet subnet-03e973be1484abecd in zone: us-east-1a, region us-east-1"
time="2024-05-23 23:37:17" level=info msg="Subnet subnet-0247dd6909aae1d5e in zone: us-east-1a, region us-east-1"
time="2024-05-23 23:37:17" level=info msg="Got no public subnet for current zone us-east-1b, going to create one"
time="2024-05-23 23:37:17" level=info msg="Created subnet subnet-0eb6b55c0a49a8233 for vpc vpc-0d0a597b147ae95db"
time="2024-05-23 23:37:18" level=info msg="Created subnet with ID subnet-0eb6b55c0a49a8233"
time="2024-05-23 23:37:19" level=info msg="Associate route table success rtbassoc-088737997c98a6fc4"
time="2024-05-23 23:37:20" level=info msg="Create route success for route table: rtb-0748b8588da1894e5"
time="2024-05-23 23:37:20" level=info msg="Tag resource subnet-0eb6b55c0a49a8233 successfully"
time="2024-05-23 23:37:20" level=info msg="Got no proper private subnet for current zone us-east-1b, going to create one"
time="2024-05-23 23:37:22" level=info msg="Created subnet subnet-0617c69a0b84f6214 for vpc vpc-0d0a597b147ae95db"
time="2024-05-23 23:37:22" level=info msg="Created subnet with ID subnet-0617c69a0b84f6214"
time="2024-05-23 23:37:23" level=info msg="Associate route table success rtbassoc-0c515055d20237b57"
time="2024-05-23 23:37:23" level=info msg="Found existing nat gateway: nat-009f045d48b1d56c8"
time="2024-05-23 23:37:24" level=info msg="Create route success for route table: rtb-04fe52f9d621ee316"
time="2024-05-23 23:37:24" level=info msg="Tag resource subnet-0617c69a0b84f6214 successfully"
time="2024-05-23 23:37:24" level=info msg="Going to prepare proper pair of subnets"
time="2024-05-23 23:37:24" level=info msg="Subnet subnet-03e973be1484abecd in zone: us-east-1a, region us-east-1"
time="2024-05-23 23:37:24" level=info msg="Subnet subnet-0247dd6909aae1d5e in zone: us-east-1a, region us-east-1"
time="2024-05-23 23:37:24" level=info msg="Subnet subnet-0eb6b55c0a49a8233 in zone: us-east-1b, region us-east-1"
time="2024-05-23 23:37:24" level=info msg="Subnet subnet-0617c69a0b84f6214 in zone: us-east-1b, region us-east-1"
time="2024-05-23 23:37:24" level=info msg="Got no public subnet for current zone us-east-1c, going to create one"
time="2024-05-23 23:37:25" level=info msg="Created subnet subnet-0839175923df61cc0 for vpc vpc-0d0a597b147ae95db"
time="2024-05-23 23:37:26" level=info msg="Created subnet with ID subnet-0839175923df61cc0"
time="2024-05-23 23:37:27" level=info msg="Associate route table success rtbassoc-0d00837f0072dcc00"
time="2024-05-23 23:37:27" level=info msg="Create route success for route table: rtb-02e0da4d3d7d055e2"
time="2024-05-23 23:37:28" level=info msg="Tag resource subnet-0839175923df61cc0 successfully"
time="2024-05-23 23:37:28" level=info msg="Got no proper private subnet for current zone us-east-1c, going to create one"
time="2024-05-23 23:37:31" level=info msg="Created subnet subnet-03369924ba6f63d76 for vpc vpc-0d0a597b147ae95db"
time="2024-05-23 23:37:32" level=info msg="Created subnet with ID subnet-03369924ba6f63d76"
time="2024-05-23 23:37:32" level=info msg="Associate route table success rtbassoc-022eded800efd6468"
time="2024-05-23 23:37:33" level=info msg="Found existing nat gateway: nat-009f045d48b1d56c8"
time="2024-05-23 23:37:34" level=info msg="Create route success for route table: rtb-02b4b2a9f64c29c63"
time="2024-05-23 23:37:34" level=info msg="Tag resource subnet-03369924ba6f63d76 successfully"
time="2024-05-23 23:37:34" level=info msg="Preparing OCM testing kms key"
time="2024-05-23 23:38:30" level=info msg="Configuring sts roles to key polilies of arn:aws:kms:us-east-1:301721915996:key/98921dbd-4b27-4b1a-934b-107ab5d73e5c"
•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Ran 1 of 80 Specs in 401.724 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 79 Skipped
PASS

Ginkgo ran 1 suite in 6m48.735606645s
Test Suite Passed

@yuwang-RH
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link
Contributor

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xueli181114, yuwang-RH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 27, 2024

@xueli181114: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 88e6525 into openshift:master May 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants