Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new alias for managed service commands #698

Merged
merged 1 commit into from
May 5, 2022

Conversation

renan-campos
Copy link
Contributor

No description provided.

@vkareh
Copy link
Member

vkareh commented May 3, 2022

The alias doesn't show up when calling --help. Do we want to make managed-service the default one? @arendej

@arendej
Copy link
Contributor

arendej commented May 3, 2022

Do we want to make managed-service the default one? @arendej

Yes please

@renan-campos
Copy link
Contributor Author

Do we want to make managed-service the default one? @arendej

Yes please

Changed it! Just fyi though: these commands are still hidden from help

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@renan-campos: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkareh
Copy link
Member

vkareh commented May 5, 2022

/lgtm

@arendej, I just want to voice my disapproval of the resource name. This should be rosa create appliance. Names like "[Managed] Service" are already overloaded... 😛

Still, code change LGTM. Merging.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: renan-campos, vkareh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@openshift-merge-robot openshift-merge-robot merged commit fbd1c77 into openshift:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants