Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fedramp: Add environment-specific configuration #702

Merged
merged 5 commits into from
Jul 19, 2022

Conversation

vkareh
Copy link
Member

@vkareh vkareh commented May 10, 2022

To support using ROSA against the FedRAMP deployment of the OCM API, we
override all authentication configuration and API endpoints. We can
determine that the user intends on using FedRAMP if they explicitly set
a GovCloud region, use an encrypted refresh token, or explicitly set the
'govcloud' flag during login.

To allow users to login against the development FedRAMP GovCloud
environment, we add a way of tracking the various APIs and AWS Cognito
user pool and client data.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@vkareh vkareh force-pushed the rosa-cognito branch 3 times, most recently from 02d1ba0 to aa65d1b Compare May 19, 2022 14:47
@vkareh vkareh changed the title login: Allow tokens without 'typ' claim govcloud: Support Cognito authentication May 19, 2022
@vkareh vkareh changed the title govcloud: Support Cognito authentication govcloud: Support AWS Cognito authentication May 19, 2022
@vkareh vkareh force-pushed the rosa-cognito branch 7 times, most recently from 9c36c42 to fc7eecf Compare May 26, 2022 15:46
@vkareh vkareh force-pushed the rosa-cognito branch 2 times, most recently from b23e57c to f879f06 Compare May 27, 2022 21:56
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2022
@vkareh vkareh force-pushed the rosa-cognito branch 3 times, most recently from 9d59e2b to d967741 Compare June 8, 2022 19:10
@vkareh vkareh changed the title govcloud: Support AWS Cognito authentication fedramp: Add environment-specific configuration Jun 8, 2022
@vkareh vkareh force-pushed the rosa-cognito branch 5 times, most recently from f54806e to 683336c Compare July 14, 2022 12:12
@vkareh vkareh force-pushed the rosa-cognito branch 3 times, most recently from 8c3f9bb to bd0dbe5 Compare July 15, 2022 17:18
To support using ROSA against the FedRAMP deployment of the OCM API, we
override all authentication configuration and API endpoints. We can
determine that the user intends on using FedRAMP if they explicitly set
a GovCloud region, use an encrypted refresh token, or explicitly set the
'govcloud' flag during login.

To allow users to login against the development FedRAMP GovCloud
environment, we add a way of tracking the various APIs and AWS Cognito
user pool and client data.
@vkareh
Copy link
Member Author

vkareh commented Jul 15, 2022

@dustman9000 @mjlshen @tonytheleg @markturansky - please take a look and confirm that this latest version works for you (with the correct vanity URLs, on all environments). Would be nice to get this merged/released soon.

@tonytheleg
Copy link
Contributor

tonytheleg commented Jul 15, 2022

@dustman9000 @mjlshen @tonytheleg @markturansky - please take a look and confirm that this latest version works for you (with the correct vanity URLs, on all environments). Would be nice to get this merged/released soon.

Currently Integration is working with the vanity URLs but changes still need applying in Stage and Prod

@tonytheleg
Copy link
Contributor

tonytheleg commented Jul 19, 2022

@vkareh Vanity URLs are fixed and this is good to go! Ive tested it in Int, Stage and Prod.

@tonytheleg
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tonytheleg, vkareh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2022

@vkareh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dustman9000
Copy link
Member

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 19, 2022
@openshift-ci openshift-ci bot merged commit 00ac12a into openshift:master Jul 19, 2022
@dustman9000
Copy link
Member

/remove-label tide/merge-method-squash

@openshift-ci openshift-ci bot removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 19, 2022
pvasant added a commit to pvasant/rosa that referenced this pull request Jul 20, 2022
- Fix typo in error message when looking up account role prefix
- fix for - Not able to remove or add a new cluster-admin in rosa cli fix for - Can't create temporary admin user for ROSA cluster
- Create cluster - validate availability zones count interactively
- Delete admin should not deleted htpasswd idp as the htpasswd list is not empty
- fedramp: Add environment-specific configuration (openshift#702)
@pvasant pvasant mentioned this pull request Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants