Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-42252: [release-4.17] Preserve user defined annotations on SriovNetworks #1008

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

OCPBUGS-42252: [release-4.17] Preserve user defined annotations on SriovNetworks #1008

wants to merge 1 commit into from

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Sep 20, 2024

@zeeke
Preserve user defined annotations on SriovNetworks
fe01085 
If an SriovNetwork is created with some annotations, the operator
deletes them during the creation of  the related NetworkAttachmentDefinition.

Make the reconcilers append the `last-network-namespace` annotation
without deleting existing ones.

The same concept applies for `SriovIbNetworks` and `OVSNetworks`

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@zeeke
Copy link
Contributor Author

zeeke commented Sep 20, 2024

/jira cherrypick OCPBUGS-41352

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-41352 has been cloned as Jira Issue OCPBUGS-42252. Will retitle bug to link to clone.
/retitle OCPBUGS-42252: [release-4.17] Preserve user defined annotations on SriovNetworks

In response to this:

/jira cherrypick OCPBUGS-41352

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@openshift-ci openshift-ci bot changed the title [release-4.17] Preserve user defined annotations on SriovNetworks OCPBUGS-42252: [release-4.17] Preserve user defined annotations on SriovNetworks Sep 20, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 20, 2024
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-42252, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-41352 to target a version in 4.18.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.17 backport of:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zeeke
Copy link
Contributor Author

zeeke commented Sep 20, 2024

/test e2e-telco5g-sriov

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pliurh pliurh Awaiting requested review from pliurh

@SalDaniele SalDaniele Awaiting requested review from SalDaniele

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeeke @openshift-ci-robot