Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.9] Bug 2028256: Sync upstream: 2021-10-20 #595

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #570

/assign EmilienM

e0ne and others added 2 commits December 1, 2021 19:51
Until k8snetworkplumbingwg/sriov-network-device-plugin#276
wiill be fixed we need to restart device plugin pod each time after
SR-IOV Network Operator plugin applied. It's needed because plugin
could change a number of VF resources even if config is not changed.
@EmilienM
Copy link
Member

EmilienM commented Dec 1, 2021

/retitle [release-4.9] Bug 2015834: Sync upstream: 2021-10-20

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2015481: Sync upstream: 2021-10-20 [release-4.9] Bug 2015834: Sync upstream: 2021-10-20 Dec 1, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2015834, which is invalid:

  • expected dependent Bugzilla bug 2015481 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2015834: Sync upstream: 2021-10-20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

@openshift-cherrypick-robot: Bugzilla bug 2015481 has been cloned as Bugzilla bug 2028256. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2028256: Sync upstream: 2021-10-20

In response to this:

[release-4.9] Bug 2015481: Sync upstream: 2021-10-20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2015834: Sync upstream: 2021-10-20 [release-4.9] Bug 2028256: Sync upstream: 2021-10-20 Dec 1, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2028256, which is invalid:

  • expected dependent Bugzilla bug 2015481 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2028256: Sync upstream: 2021-10-20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign pliurh after the PR has been reviewed.
You can assign the PR to them by writing /assign @pliurh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zshi-redhat
Copy link
Contributor

zshi-redhat commented Dec 2, 2021

@EmilienM I think we only need commit Check if generic_plugin is loaded before invoking it to fix the associated BZ. The 4.10 PR is a backport from upstream which contains multiple unrelated commits.

@EmilienM
Copy link
Member

EmilienM commented Dec 2, 2021

@EmilienM I think we only need commit Check if generic_plugin is loaded before invoking it to fix the associated BZ. The 4.10 PR is a backport from upstream which contains multiple unrelated commits.

Unfortunately I can't push over this PR:

git push -f
remote: Permission to openshift-cherrypick-robot/sriov-network-operator.git denied to EmilienM.
fatal: unable to access 'https://github.com/openshift-cherrypick-robot/sriov-network-operator.git/': The requested URL returned error: 403

because it was done by OpenShift Cherrypick robot. I'll duplicate the PR and close this one.

@EmilienM
Copy link
Member

EmilienM commented Dec 2, 2021

/close
in favour of #597

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2021

@EmilienM: Closed this PR.

In response to this:

/close
in favour of #597

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Dec 2, 2021
SchSeba pushed a commit to SchSeba/sriov-network-operator that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants