ensure network daemon checks if machineConfigPool resource registered before attempting to pause the MachineConfigPool #683
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: relyt0925 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… before attempting to pause the MachineConfigPool In hypershift: there are no machineConfigPool resources registered and therefore no need to pause the MachineConfigPool resource when sriov-network-operator is orchestrating sr-iov configuration. This adds a check to see if that api resource is registered with the cluster before attempting to pause the machineConfigPool resource
relyt0925
force-pushed
the
hypershift-compatibility
branch
from
a552123
to
50418d9
Compare
|
/retest |
|
@relyt0925: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @relyt0925 please open the PR on the u/s repo https://github.com/k8snetworkplumbingwg/sriov-network-operator Thanks! |
|
@SchSeba: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thank you for the guidance: PR is now here: |
Make OVS_CNI_IMAGE truly optional
In hypershift: there are no machineConfigPool resources registered and therefore no need to pause the MachineConfigPool resource when sriov-network-operator is orchestrating sr-iov configuration. This adds a check to see if that api resource is registered with the cluster before attempting to pause the machineConfigPool resource.
This would prevent the need from having to use CLUSTER_TYPE: "kubernetes" in hypershift clusters in order to get sriov-network-operator to work in those environments.