Support Graceful Shutdown #751
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jerpeter1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Exploring this as a possibly less-risky alternative to involving signal handlers to supporting graceful shutdown. If a node's kubelet doesn't have gracefulShutdown configured, this should do nothing, and if it does, it should delay preStop for a little while. |
|
/test all |
|
/test e2e-openstack-nfv-hwoffload |
jerpeter1
force-pushed
the
support-graceful-shutdown
branch
from
c172e33
to
528f386
Compare
|
/test all |
jerpeter1
force-pushed
the
support-graceful-shutdown
branch
from
528f386
to
36ea2d8
Compare
If the kubelet where the the sriov pod is running has gracefulShutdown configured, we'll delay in preStop for a while if and while /tmp/sriov-delay-shutdown exists, up to a maximum wait that's less than 15 minutes (which is now specified in the daemonset pod's terminationGracePeriodSeconds).
jerpeter1
force-pushed
the
support-graceful-shutdown
branch
from
36ea2d8
to
87ecbb3
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Waiting for upstream PR to merge: k8snetworkplumbingwg/sriov-network-operator#416 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@jerpeter1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @jerpeter1 I am closing this one we continue to work on the u/s and then we do a full sync between all the PRs /close |
|
@SchSeba: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If the kubelet where the the sriov pod is running has gracefulShutdown configured, we'll delay in preStop for a while if and while
/tmp/sriov-delay-shutdownexists in the host filesystem, up to a maximum wait that's less than 15 minutes (which is now specified in the daemonset pod's terminationGracePeriodSeconds).