OCPBUGS-28248: Downstream Sync 2024-02-01 #882
Conversation
This commit changes the behavior of the webhook when deleting the default SriovNetworkNodePolicy and SriovOperatorConfig. This change is needed so that we can smoothly uninstall Helm releases that have the webhooks enabled. Without this change, when running `helm uninstall`, it fails because the webhook doesn't allow deletion of such resources mentioned above. Since these Webhook Configurations resources are deployed via the controller itself and not Helm, it's much more difficult to handle the lifecycle of them via Helm in the current state. Instead, it's easier to send a warning that these resources should not be deleted. Signed-off-by: Vasilis Remmas <vremmas@nvidia.com>
Signed-off-by: Vasilis Remmas <vremmas@nvidia.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
like openstack and openshift add interfaces and mocks for better unit test Signed-off-by: Sebastian Sch <sebassch@gmail.com>
for example MLX special mstconfig wrapper and create mock for unit tests Signed-off-by: Sebastian Sch <sebassch@gmail.com>
…kage create also interfaces for everything so we can have better unit tests coverage Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Change the `kubeVersion` constraint to permit pre-release versions as per: https://helm.sh/docs/chart_template_guide/function_list/#working-with-prerelease-versions
…onfig-delete-behavior Change behavior when deleting default SriovNetworkNodePolicy and SriovOperatorConfig
Update chart README.md to reflect webhook changes
Update Helm chart kubeVersion check
…aces Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Interface redesign
go-get-tool is not available in the Makefile Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Use go-install-tool instead of go-get-tool for gomock
When interface(pf) is externally managed, we need to avoid resetting firmware configurations. - use store manager to get latest pf config from host so we can reliably determine if interface is externally managed if it does not appear in spec - when interface appears in spec, block both sriov and link type firmware configurations if interface is externally managed - skip pfs that are externally managed Signed-off-by: adrianc <adrianc@nvidia.com>
Signed-off-by: adrianc <adrianc@nvidia.com>
…-fixes Externally managed fixes
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
This field should be used to report information about type of the VDPA device that is configured for VF. Empty string means that there is no VDPA device. Valid values are: `virtio`, `vhost` (same as in `SriovNetworkNodePolicySpec`) Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Update golang to 1.21
…ing-design add design doc for switchdev mode refactoring
Add disable plugins
Refactoring in [1] left the openstackContext uninitialized. [1] k8snetworkplumbingwg/sriov-network-operator#553 Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
openshift-ci
bot
added
the
do-not-merge/hold
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
- Move Manager creation and initialization to each controller test - Move creation of k8s objs that are not common for all controllers to each controller test - Use ordered containers to only setup manager once per controller test - remove the usage of context.TODO() from tests Signed-off-by: adrianc <adrianc@nvidia.com>
e2e: Fix `Debug logging should be visible in multus pod` flake
add w/a for multus bug in CI
Fix typo in mellanox plugin name in logs
…ch-test Refactor controller tests
- move log level handling earlier in reconcile flow - add log msg when reconicle has completed successfully Signed-off-by: adrianc <adrianc@nvidia.com>
…operator-config minor improvements in sriovOpeatorConfig controller
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
e2e: dump multus namespace
The configmap is created by the operator but never deleted. Set OwnerReference to SriovOperatorConfig default CR to ensure its deletion. Signed-off-by: adrianc <adrianc@nvidia.com>
Set OwnerReference to sriov-device-plugin configmap
openstack: Fix `nil` HostManager in `openstackContext`
openshift-ci
bot
removed
the
do-not-merge/hold
|
@zeeke: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wizhaoredhat, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@zeeke: Jira Issue OCPBUGS-28248: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28248 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-operator-container-v4.16.0-202402140210.p0.g842a9f1.assembly.stream.el9 for distgit sriov-network-operator. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build sriov-network-config-daemon-container-v4.16.0-202402140210.p0.g842a9f1.assembly.stream.el9 for distgit sriov-network-config-daemon. |
Clean merge, no conflicts.
Aligned field
SriovNetworkNodeState.Status.Interfaces.Vfs.VdpaTypeRefs: