Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-36307,OCPBUGS-36308: 416 critical bugs #946

Merged
merged 3 commits into from
Jul 3, 2024
Merged

OCPBUGS-36307,OCPBUGS-36308: 416 critical bugs #946

merged 3 commits into from
Jul 3, 2024

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Jun 28, 2024

zeeke and others added 3 commits June 28, 2024 10:03
@zeeke
Avoid reconciling field Webhook.ClientConfig.CABundle
42905de 
Webhook resources (`ValidatingWebhookConfiguration` and `MutatingWebhookConfiguration`) in OpenShift
are configured with `service.beta.openshift.io/inject-cabundle` in a way that
a third component fills the ClientConfig.CABundle field of the webhook.
When reconciling webhooks, do not override the field and avoid a flakiness, as
there might be a time slot in which the API server is not configured with a valid
client certificate:

```
Error from server (InternalError): error when creating "policies": Internal error occurred: failed calling webhook "operator-webhook.sriovnetwork.openshift.io": failed to call webhook: Post "https://operator-webhook-service.openshift-sriov-network-operator.svc:443/mutating-custom-resource?timeout=10s": tls: failed to verify certificate: x509: certificate signed by unknown authority
```

The same behavior also happens when using CertManager

Refs:
- https://docs.openshift.com/container-platform/4.15/security/certificates/service-serving-certificate.html
- https://issues.redhat.com/browse/OCPBUGS-32139
- https://cert-manager.io/docs/concepts/ca-injector/

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@SchSeba @zeeke
add sort for the policy on the sriovOperatorConfig controller
7eaa583 
we need to be consistent with the policy order

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@zeeke
Run go mod tidy and go mod vendor
0c6dd00 
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@openshift-ci openshift-ci bot requested review from bn222 and pliurh June 28, 2024 08:15
@zeeke
Copy link
Contributor Author

zeeke commented Jun 28, 2024

/jira cherrypick OCPBUGS-32139

@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-32139 has been cloned as Jira Issue OCPBUGS-36307. Will retitle bug to link to clone.
/retitle OCPBUGS-36307: 416 critical bugs

In response to this:

/jira cherrypick OCPBUGS-32139

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title 416 critical bugs OCPBUGS-36307: 416 critical bugs Jun 28, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 28, 2024
@zeeke
Copy link
Contributor Author

zeeke commented Jun 28, 2024

/jira cherrypick OCPBUGS-36243

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 28, 2024
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-36307, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32139 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.16 Backport of:

/jira cherrypick OCPBUGS-32139
/jira cherrypick OCPBUGS-36243

cc @SchSeba, @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-36243 has been cloned as Jira Issue OCPBUGS-36308. Will retitle bug to link to clone.
/retitle OCPBUGS-36308: OCPBUGS-36307: 416 critical bugs

In response to this:

/jira cherrypick OCPBUGS-36243

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title OCPBUGS-36307: 416 critical bugs OCPBUGS-36308: OCPBUGS-36307: 416 critical bugs Jun 28, 2024
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-36308, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-36243 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.16 Backport of:

/jira cherrypick OCPBUGS-32139
/jira cherrypick OCPBUGS-36243

cc @SchSeba, @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zeeke
Copy link
Contributor Author

zeeke commented Jun 28, 2024

/retitle OCPBUGS-36308: OCPBUGS-36307,OCPBUGS-36308: 416 critical bugs

@zeeke
Copy link
Contributor Author

zeeke commented Jun 28, 2024

/retitle OCPBUGS-36307,OCPBUGS-36308: 416 critical bugs

@openshift-ci openshift-ci bot changed the title OCPBUGS-36308: OCPBUGS-36307: 416 critical bugs OCPBUGS-36308: OCPBUGS-36307,OCPBUGS-36308: 416 critical bugs Jun 28, 2024
@openshift-ci openshift-ci bot changed the title OCPBUGS-36308: OCPBUGS-36307,OCPBUGS-36308: 416 critical bugs OCPBUGS-36307,OCPBUGS-36308: 416 critical bugs Jun 28, 2024
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-36307, which is invalid:

  • expected dependent Jira Issue OCPBUGS-32139 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-36308, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-36243 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.16 Backport of:

/jira cherrypick OCPBUGS-32139
/jira cherrypick OCPBUGS-36243

cc @SchSeba, @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@SchSeba
Copy link
Contributor

SchSeba commented Jun 28, 2024

great work thanks!

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 28, 2024

@zeeke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 0c6dd00 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SchSeba
Copy link
Contributor

SchSeba commented Jun 30, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 30, 2024
@ajaggapa
Copy link

ajaggapa commented Jul 3, 2024

/label cherry-pick-approved

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

@ajaggapa: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gkopels
Copy link

gkopels commented Jul 3, 2024

/label cherry-pick-approved

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

@gkopels: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@evgenLevin
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 3, 2024
@zeeke
Copy link
Contributor Author

zeeke commented Jul 3, 2024

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-36307, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-32139 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32139 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

This pull request references Jira Issue OCPBUGS-36308, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi July 3, 2024 13:11
@zeeke
Copy link
Contributor Author

zeeke commented Jul 3, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 3, 2024
@openshift-ci-robot
Copy link
Contributor

@zeeke: This pull request references Jira Issue OCPBUGS-36307, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-32139 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-32139 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

This pull request references Jira Issue OCPBUGS-36308, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-36243 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36243 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 18db263 into openshift:release-4.16 Jul 3, 2024
10 of 11 checks passed
@openshift-ci-robot
Copy link
Contributor

@zeeke: Jira Issue OCPBUGS-36307: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36307 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-36308: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36308 has been moved to the MODIFIED state.

In response to this:

4.16 Backport of:

/jira cherrypick OCPBUGS-32139
/jira cherrypick OCPBUGS-36243

cc @SchSeba, @bn222

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build sriov-network-operator-container-v4.16.0-202407031636.p0.g18db263.assembly.stream.el9 for distgit sriov-network-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bn222 bn222 Awaiting requested review from bn222

@pliurh pliurh Awaiting requested review from pliurh

@zhaozhanqi zhaozhanqi Awaiting requested review from zhaozhanqi

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@SchSeba SchSeba

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.