OCPBUGS-38010: [release-4.16]: Skip firmware reset on devices the operator doesn't control

[zeeke]

4.16 Backport of

• Skip firmware reset on devices the operator doesn't control k8snetworkplumbingwg/sriov-network-operator#734
• Return error on mlx plugin on firmware reset check k8snetworkplumbingwg/sriov-network-operator#743

no conflicts

This should fix the failing test

[It] [sriov] operator Custom SriovNetworkNodePolicy ExternallyManaged Validation Should create a policy if the number of requested vfs is equal and not delete them when the policy is removed

cc @SchSeba

[zeeke]

/jira cherrypick OCPBUGS-36683

[openshift-ci-robot]

@zeeke: Jira Issue OCPBUGS-36683 has been cloned as Jira Issue OCPBUGS-38010. Will retitle bug to link to clone.
/retitle OCPBUGS-38010: [release-4.16]: Skip firmware reset on devices the operator doesn't control

In response to this:

/jira cherrypick OCPBUGS-36683

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@zeeke: This pull request references Jira Issue OCPBUGS-38010, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-36683 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
• expected dependent Jira Issue OCPBUGS-36683 to target a version in 4.17.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

4.16 Backport of

• Skip firmware reset on devices the operator doesn't control k8snetworkplumbingwg/sriov-network-operator#734
• Return error on mlx plugin on firmware reset check k8snetworkplumbingwg/sriov-network-operator#743

no conflicts

This should fix the failing test

[It] [sriov] operator Custom SriovNetworkNodePolicy ExternallyManaged Validation Should create a policy if the number of requested vfs is equal and not delete them when the policy is removed

cc @SchSeba

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[SchSeba]

/jira refresh

[openshift-ci-robot]

@SchSeba: This pull request references Jira Issue OCPBUGS-38010, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.z) matches configured target version for branch (4.16.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-36683 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-36683 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (elevin@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[SchSeba]

/lgtm
/approve
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SchSeba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[evgenLevin]

/label cherry-pick-approved

[openshift-ci-robot]

@zeeke: Jira Issue OCPBUGS-38010: All pull requests linked via external trackers have merged:

• openshift/sriov-network-operator#980

Jira Issue OCPBUGS-38010 has been moved to the MODIFIED state.

In response to this:

4.16 Backport of

• Skip firmware reset on devices the operator doesn't control k8snetworkplumbingwg/sriov-network-operator#734
• Return error on mlx plugin on firmware reset check k8snetworkplumbingwg/sriov-network-operator#743

no conflicts

This should fix the failing test

[It] [sriov] operator Custom SriovNetworkNodePolicy ExternallyManaged Validation Should create a policy if the number of requested vfs is equal and not delete them when the policy is removed

cc @SchSeba

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-config-daemon
This PR has been included in build sriov-network-config-daemon-container-v4.16.0-202408120337.p0.g48d1049.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-operator
This PR has been included in build sriov-network-operator-container-v4.16.0-202408120337.p0.g48d1049.assembly.stream.el9.
All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: sriov-network-webhook
This PR has been included in build sriov-network-webhook-container-v4.16.0-202408120337.p0.g48d1049.assembly.stream.el9.
All builds following this will include this PR.

[SchSeba]

/cherry-pick release-4.15

[SchSeba]

/cherrypick release-4.15

[openshift-cherrypick-robot]

@SchSeba: #980 failed to apply on top of branch "release-4.15":

Applying: implement RemovePfAppliedStatus function in store
Applying: Remove store file on reset
Applying: Skip firmware reset for devices we don't control
Applying: implement functional test for both regular and externally manage
Using index info to reconstruct a base tree...
M	test/conformance/tests/test_sriov_operator.go
Falling back to patching base and 3-way merge...
Auto-merging test/conformance/tests/test_sriov_operator.go
CONFLICT (content): Merge conflict in test/conformance/tests/test_sriov_operator.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 implement functional test for both regular and externally manage
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@SchSeba: #980 failed to apply on top of branch "release-4.15":

Applying: implement RemovePfAppliedStatus function in store
Applying: Remove store file on reset
Applying: Skip firmware reset for devices we don't control
Applying: implement functional test for both regular and externally manage
Using index info to reconstruct a base tree...
M	test/conformance/tests/test_sriov_operator.go
Falling back to patching base and 3-way merge...
Auto-merging test/conformance/tests/test_sriov_operator.go
CONFLICT (content): Merge conflict in test/conformance/tests/test_sriov_operator.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 implement functional test for both regular and externally manage
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.