Add search by QR code option in register #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ellykits
requested changes
Jul 12, 2024
...id/quest/src/main/java/org/smartregister/fhircore/quest/util/extensions/ContextExtensions.kt
Outdated
Show resolved
Hide resolved
ellykits
reviewed
Jul 12, 2024
Comment on lines
203
to
209
| Icon( | ||
| imageVector = Icons.Filled.Clear, | ||
| CLEAR, | ||
| tint = Color.Gray, | ||
| modifier = modifier.testTag(TRAILING_ICON_TEST_TAG), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Can we have the clear button at the end?
There was a problem hiding this comment.
Minor request: fix the padding on the icons
There was a problem hiding this comment.
Can we have the clear button at the end?
There was a problem hiding this comment.
Minor request: fix the padding on the icons
What size is currently being used for fhircore?
There was a problem hiding this comment.
Further reviewing of the designs shared, it seems the qr-code icon gets hidden when the clear button is shown, and so I've reverted the change to match that
to match design
ellykits
approved these changes
Jul 16, 2024
ellykits
pushed a commit
that referenced
this pull request
Aug 7, 2024
* Override barcode layout to contain required missing views * Update qr code scanning implementation * Document qr_code widget extension * Isolate qr scanning functionality to QrCodeCameraDialogFragment * Use QrCodeScanUtils to abstract barcode scanning implementation * Support search by QR code config in register search * Move clear button to show as last in register search * Hide qr/barcode icon when showing clear text icon to match design * Wrap search text in a SearchQuery class to track mode of search * Support going to profile directly after QR scan for single result * Add search by QR code option in register (#3379) * Support search by QR code config in register search * Move clear button to show as last in register search * Hide qr/barcode icon when showing clear text icon to match design * Refactor replace 'barcode' with 'qrCode' * Add relevant tests * Upload ci test results to get info on test fails * Refactor qr code single result action to support available workflows * Upload test results as ci artifacts to save test logs * test(EditTextQrCodeViewHolderFactory): Fix InstantionError * Update qr-code widget extension to use codeableConcept * Add ActionTrigger ON_SEARCH_SINGLE_RESULT * Fix indefinite loop on ActionConfig handleClick * Extend QR Code widget to support adding multiple QR codes * Add kdoc to UiSearchQuery data class * Fix test compilation errors * Resolve initial review comments * Fix qr code scan when repeat false Questionnaire item with linkId qr-code-uuid-widget does not allow repeated answers * Fix ON_SEARCH_SINGLE_RESULT action trigger for profile launch * Rename ConfigExtensionsTest to ConfigExtensionsKtTest to fix coverage ?? * Update tests for EditTextQrCodeItemViewHolderFactory * Update tests for EditTextQrCodeViewHolderFactory * Resolve requested changes * Fix profile launch always redirecting on single search result * Revert to use find since Iterable#find internally seems to just use firstOrNull * Add ui android tests for RegisterScreen * Refactor test for QrCodeScanUtils#scanQrCode --------- Co-authored-by: Peter Lubell-Doughtie <peter@ona.io> Co-authored-by: Allan Onchuru <16164649+allan-on@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3351
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile