Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kujaku library. #3446

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Update kujaku library. #3446

merged 5 commits into from
Aug 16, 2024

Conversation

Lentumunai-Mark
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3431

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.1%. Comparing base (490c294) to head (52fce94).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              main   #3446    +/-   ##
========================================
  Coverage     27.0%   27.1%            
- Complexity     720     733    +13     
========================================
  Files          269     275     +6     
  Lines        13517   13756   +239     
  Branches      2433    2491    +58     
========================================
+ Hits          3662    3733    +71     
- Misses        9373    9528   +155     
- Partials       482     495    +13     
Flag Coverage Δ
engine 64.6% <ø> (+<0.1%) ⬆️
geowidget 11.4% <ø> (ø)
quest 5.2% <ø> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Lentumunai-Mark and others added 4 commits August 16, 2024 13:21
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@Lentumunai-Mark Lentumunai-Mark marked this pull request as ready for review August 16, 2024 12:18
@f-odhiambo f-odhiambo added this pull request to the merge queue Aug 16, 2024
@f-odhiambo f-odhiambo removed this pull request from the merge queue due to a manual request Aug 16, 2024
@f-odhiambo f-odhiambo merged commit e2f89d9 into main Aug 16, 2024
5 checks passed
@f-odhiambo f-odhiambo deleted the update-kujaku-library branch August 16, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update permissions checker is use on Geo-widget module
3 participants