Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the diff3_merge module while trying to merge remote changes #3058

Closed
deepbasu007 opened this issue Apr 11, 2016 · 1 comment
Closed
Labels
bug A bug - let's fix this! chore-dependency Improvements to one of iD's dependencies

Comments

@deepbasu007
Copy link

For certain values of nodes and ways, the diff3_merge module fails to merge the remote changes correctly, even when there is no conflict.

Here's an example where issues occur:

a = ["n4100522632", "n4100697091", "n4100697136", "n-10000", "n4102671583", "n4102671584", "n4102671585", "n4102671586", "n4102671587", "n4102671588", "n4102677889", "n4102677890", "n4094374176"]

o = ["n4100522632", "n4100697091", "n4100697136", "n4102671583", "n4102671584", "n4102671585", "n4102671586", "n4102671587", "n4102671588", "n4102677889", "n4102677890", "n4094374176"]

b = ["n4100522632", "n4100697091", "n4100697136", "n4102671583", "n4102671584", "n4102671585", "n4102671586", "n4102671587", "n4102671588", "n4102677889", "n4105613618", "n4102677890", "n4105613617", "n4094374176"]

merged result from diff3_merge
= ["n4100522632", "n4100697091", "n4100697136", "n4102671583", "n4102671584", "n4102671585", "n4102671586", "n4102671587", "n4102671588", "n4102677889", "n4105613618", "n4102677890", "n4102671583", "n4102671584", "n4102671585", "n4102671586", "n4102671587", "n4102671588", "n4102677889", "n4102677890", "n4094374176"]

GNU diff3 result
= ["n4100522632", "n4100697091", "n4100697136", "n-10000", "n4102671583", "n4102671584", "n4102671585", "n4102671586", "n4102671587", "n4102671588", "n4102677889", "n4105613618", "n4102677890", "n4105613617", "n4094374176"]

As can be seen, the GNU diff3 result is as expected. However, the Diff3.diff3_merge fails to merge and creates ambiguities. Any clues as to what's happening here or how to fix it? Here's a screenshot of the artifacts this creates.
screen shot 2016-04-10 at 11 28 53 pm

@bhousel bhousel reopened this Apr 12, 2016
@bhousel
Copy link
Member

bhousel commented Apr 12, 2016

Discussion and possible fix here.. langram/node-diff3#3
Thanks @deepbasu007 for finding this!

@bhousel bhousel added bug A bug - let's fix this! chore-dependency Improvements to one of iD's dependencies labels Nov 1, 2016
This was referenced Oct 24, 2017
bhousel added a commit to bhousel/node-diff3 that referenced this issue Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! chore-dependency Improvements to one of iD's dependencies
Projects
None yet
Development

No branches or pull requests

2 participants