Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust rendering of node/vertex with direction #3815

Closed
bhousel opened this issue Feb 3, 2017 · 4 comments
Closed

Adjust rendering of node/vertex with direction #3815

bhousel opened this issue Feb 3, 2017 · 4 comments
Labels
map-renderer An issue with how things are rendered in the map priority A top priority issue that has a big impact or matter most to new mappers usability An issue with ease-of-use or design

Comments

@bhousel
Copy link
Member

bhousel commented Feb 3, 2017

Followup from #3115..

Some node/vertex features in OSM can have a direction. stop signs, traffic signals, billboards.
The normal method to tag this is direction=forward or direction=backward (although, this being OSM, there are of course alternative bizarro tag schemes).

Anyway, what we do with directional vertices currently is - the same as any other interestingly tagged vertex, just show it as a circle with a dot (or in some cases a maki icon):

screenshot 2017-02-03 10 35 28

But maybe we can do something else to indicate that there is a direction:

screenshot 2017-02-03 10 35 28 copy screenshot 2017-02-03 10 53 21

@bhousel bhousel added usability An issue with ease-of-use or design map-renderer An issue with how things are rendered in the map labels Feb 3, 2017
@slhh
Copy link
Contributor

slhh commented Feb 4, 2017

@bhousel What you call the bizarro tag schemes seems to be current usage of key direction according to the wiki. I think for good reason because this enables usage on any node. Forward and backward values don't have a useful meaning except for the special case of a vertex of a single way.

In case of traffic signals or traffic signs we have to differentiate two types of direction, the facing orientation the direction of the affected traffic.

Facing orientation is described using key direction in both cases using the 'bizarro' values..
Direction of traffic affected by traffic signals is described by traffic_signals:direction=forward or traffic_signals:direction=backward (https://wiki.openstreetmap.org/wiki/Key:traffic_signals:direction).
Direction of traffic affected by traffic signs is described using traffic_sign:forward=* or traffic_sign:backward=* (https://wiki.openstreetmap.org/wiki/Key:traffic_sign#On_nodes).

Therefore, direction=forward and direction=backward seem to be essentially outdated tags.

Facing orientation and direction of traffic seem to be more or less inverse directions in most cases, therefore rendering an arrow seems to be potentially confusing.

Directional tags have always to be combined with tagging a feature on the node, we might want to render the feature which could interfere with a direction indicator.

@Codain
Copy link

Codain commented Feb 23, 2017

Hi,

As a starting point I would consider to customize the node to, for instance, display a little traffic light, stop sign or give way sign in the node.

Then, speaking of a "direction" indicator the first proposition (the black and thin arrow) can be confused with a one way arrow. The second drawing might be ok in addition with previous point.

A third option to have a lighter symbology would be to replace the node and the triangle by a triangle, centerd on the node, containing the traffic light/sign and oriented to the direction tag.

@bhousel
Copy link
Member Author

bhousel commented Feb 23, 2017

As a starting point I would consider to customize the node to, for instance, display a little traffic light, stop sign or give way sign in the node.

Yes, I plan to do that separately of this issue. There are a handful of traffic control icons that we're really missing from maki. I'll open a new issue for it.

@bhousel bhousel added the priority A top priority issue that has a big impact or matter most to new mappers label Apr 22, 2017
@bhousel bhousel added the wip Work in progress label Dec 7, 2017
@bhousel bhousel closed this as completed in b79b6ca Jan 2, 2018
@bhousel
Copy link
Member Author

bhousel commented Jan 2, 2018

done in #4602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map priority A top priority issue that has a big impact or matter most to new mappers usability An issue with ease-of-use or design
Projects
None yet
Development

No branches or pull requests

3 participants