Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shop=trade , shop=tiles presets #4410

Closed
abdeldjalil09 opened this issue Oct 7, 2017 · 3 comments
Closed

shop=trade , shop=tiles presets #4410

abdeldjalil09 opened this issue Oct 7, 2017 · 3 comments
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag

Comments

@abdeldjalil09
Copy link
Contributor

abdeldjalil09 commented Oct 7, 2017 •
edited
Loading

https://wiki.openstreetmap.org/wiki/Tag:shop=trade
https://wiki.openstreetmap.org/wiki/Tag:shop%3Dtiles
@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! Hacktoberfest preset An issue with an OpenStreetMap preset or tag labels Oct 7, 2017
@iblancasa
Copy link

Could you add more information about what is this issue about?

Thank you :)

@bhousel
Copy link
Member

bhousel commented Oct 8, 2017 •
edited
Loading

Sure @iblancasa, the preset system is explained in this README. The presets and fields are all defined in .json files under data/presets/...

We're looking for:

  • A new preset file data/presets/presets/shop/tiles.json - it should look like any of the other files inside the shop folder.. You can just copy an existing file like data/presets/presets/shop/tobacco.json and change the "name" to say "Tile Shop" and "tags" to say "shop": "tiles".
  • A new preset file data/presets/presets/shop/trade.json - same as with tiles, copy an existing shop preset, change "name" ("Trade Shop") and "tags" ("shop": "trade")
  • A new field file data/presets/fields/trade.json - This will let people pick from a list of common values what trade the "Trade Shop" is for. You can copy an existing file like data/presets/fields/tourism.json, and change the "key" to "trade" and label to "Trade".
  • To make the trade field appear on the trade preset, open data/presets/presets/shop/trade.json that you just created, and add "trade" to the "fields" array. You can put it after "name", since it is kind of important (the order in the array is the order they'll display on the screen).

@TheGreenToaster TheGreenToaster mentioned this issue Oct 8, 2017
Merged
TheGreenToaster pushed a commit to TheGreenToaster/iD that referenced this issue Oct 8, 2017
@wingra2
Added Trade Shop presets openstreetmap#4410
ae935a5
@TheGreenToaster TheGreenToaster mentioned this issue Oct 8, 2017
Merged
bhousel added a commit that referenced this issue Oct 9, 2017
@bhousel
Merge pull request #4413 from TheGreenToaster/trade-presets
41023a5 
Added Trade Shop presets #4410
@bhousel
Copy link
Member

bhousel commented Oct 9, 2017

Done in #4411, #4413

@bhousel bhousel closed this as completed Oct 9, 2017
TheGreenToaster pushed a commit to TheGreenToaster/iD that referenced this issue Oct 9, 2017
@wingra2
Added files from build for openstreetmap#4410
8103c07
@TheGreenToaster TheGreenToaster mentioned this issue Oct 9, 2017
Closed
@bhousel bhousel mentioned this issue Oct 9, 2017
Closed
jgravois added a commit to jgravois/iD that referenced this issue Oct 11, 2017
@jgravois
Merge branch '2.4.3' into bumb
d2fa26a 
* 2.4.3: (37 commits)
  Check in build
  v2.4.3
  npm run translations
  npm run imagery
  2.4.3 changelog
  Allow -,_,+,& as hashtag characters
  Adjust hashtagRegex: allow '_', change * (0 or more) to + (1 or more)
  npm run build for new preset strings
  Make sure "Add Field" scrolls into view during Area chapter of walkthrough (closes openstreetmap#4417)
  Updated presets correctly
  Treat punctuation as hashtag delimiters
  Add instructions about release notes
  v2.4.2
  npm run translations
  npm run build for new presets
  Merry-go-round is synonymous with roundabout
  Renamed Springy Rocker preset to Spring Rocker
  v2.4.2 changelog
  Added Trade Shop presets openstreetmap#4410
  Increased preset list max height
  ...
@bhousel bhousel mentioned this issue Oct 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Best for first-time contributors. No experience necessary! preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bhousel @iblancasa @abdeldjalil09