Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushing enter multiple times when uploading causes multiple changesets #4641

Closed
JamesKingdom opened this issue Dec 30, 2017 · 1 comment
Closed

Pushing enter multiple times when uploading causes multiple changesets #4641

JamesKingdom opened this issue Dec 30, 2017 · 1 comment
Labels
bug-release-blocker An important bug - let's get this fixed in the next release! priority A top priority issue that has a big impact or matter most to new mappers

Comments

@JamesKingdom
Copy link
Collaborator

JamesKingdom commented Dec 30, 2017 •
edited
Loading


Everytime you push enter it creates a new copy of the objects you have changed, and makes the screen darker.
Here's the changeset list, all exactly the same
@bhousel
Copy link
Member

bhousel commented Dec 30, 2017

Whoa thanks @JamesKingdom for finding this! We've noticed a few users have been able to do this before but we didn't know what was causing it..

cc @simonpoole @maxerickson

@bhousel bhousel added bug-release-blocker An important bug - let's get this fixed in the next release! priority A top priority issue that has a big impact or matter most to new mappers labels Dec 30, 2017
bhousel added a commit that referenced this issue Jan 5, 2018
@bhousel
Improvements to save flow
0acf3b4 
- Attempt fast save first, only perform conflict resolution if necessary (re: #3056)
- Block reentry of save, and dont keep focus on save button (closes #4641)
- Refactor modeSave() for code clarity (avoid shared state in closure variables)
@bhousel bhousel mentioned this issue Jan 5, 2018
Merged
4 tasks
@bhousel bhousel added the wip Work in progress label Jan 5, 2018
@bhousel bhousel closed this as completed in a63c4a7 Jan 8, 2018
@bhousel bhousel mentioned this issue Jan 21, 2018
Merged
@bhousel bhousel removed the wip Work in progress label Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug-release-blocker An important bug - let's get this fixed in the next release! priority A top priority issue that has a big impact or matter most to new mappers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhousel @JamesKingdom