Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneway:yes is implied for motorway_link #4727

Closed
UncleGene opened this issue Jan 22, 2018 · 3 comments
Closed

oneway:yes is implied for motorway_link #4727

UncleGene opened this issue Jan 22, 2018 · 3 comments
Labels
bug A bug - let's fix this!

Comments

@UncleGene
Copy link

According to https://wiki.openstreetmap.org/wiki/Tag:highway%3Dmotorway_link, there is no implied value for it; and as oneway is a restriction, absence of the value should mean no restriction
@bhousel
Copy link
Member

bhousel commented Jan 22, 2018

Is the issue here that iD treats highway=motorway_link without a oneway tag as if it had oneway=yes, and it should instead treat it as oneway=no? (see "Assumed to be Yes" in the screenshot below)

When creating motorway_link, iD always adds a oneway tag - the question here is what to do if the way doesn't have a tag.

screenshot 2018-01-22 14 34 38

@bhousel bhousel added the waitfor-info Waiting for more info label Jan 22, 2018
@UncleGene
Copy link
Author

Yes. The issue is with the ones without oneway tag. At this moment iD confuses the user:

  • iD shows the way as oneway, so I see no incentive to fix it
  • OSRM (or any other routing engine) defaults to oneway:no, producing wrong routes

@bhousel bhousel added bug A bug - let's fix this! and removed waitfor-info Waiting for more info labels Jan 22, 2018
@bhousel
Copy link
Member

bhousel commented Jan 22, 2018

Gotcha, thanks for clarifying, I'll change what iD does 👍

jgravois added a commit to jgravois/iD that referenced this issue Jan 23, 2018
@jgravois
Merge remote-tracking branch 'upstream/master' into bump-v2.6.0
4b2c508 
* upstream/master: (206 commits)
  `barrier=kerb` can also be mapped as a line
  made desired tweaks to kerb.json
  Restore area fill from local storage including wireframe
  Added smoking area preset
  changed "water tank" to "emergency water tank"
  chore(package): update rollup to version 0.55.0
  Corrected discrepancies between upstream and local files
  changed icon to "water"
  Use dark halo around text, switch to svgPath to get viewport clipping
  `highway=motorway_link` no longer implies `oneway=yes` (closes openstreetmap#4727)
  Restore user disabled features from local storage
  Draw covered/underground lines beneath areas (closes openstreetmap#4718)
  Add religion, denomination fields to school preset (closes openstreetmap#4722)
  Add religion, denomination fields to religious landuse preset (closes openstreetmap#4721)
  added a water tank preset
  Restore latest imagery used from local storage
  Fix typo
  v2.6.0
  npm run translations
  npm run imagery
  ...
@bhousel bhousel mentioned this issue Feb 1, 2018
Merged
@Nakaner Nakaner mentioned this issue Nov 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug - let's fix this!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhousel @UncleGene