Cannot add restrictions in complex multiway junction

[srividyacb]

Area in OpenStreetMap

Red box in above image showing overlapping restriction arrow in TR editor

In the same junction cannot add only turn-restrcition for highway going straight. The restriction arrow is not going blue even after multiple clicks.

cc @bhousel

[tyrasd]

confirming. in the second case, the following exception is thrown:

graph.js:48 Uncaught Error: entity r-1 not found
    at coreGraph$$1.entity (graph.js:48)
    at action (delete_relation.js:18)
    at Array.<anonymous> (unrestrict_turn.js:11)
    at _act (history.js:59)
    at _perform (history.js:74)
    at Object.perform (history.js:168)
    at Object.perform (context.js:449)
    at SVGSVGElement.click (restrictions.js:405)
    at SVGSVGElement.<anonymous> (on.js:27)

Apparently, it tries to delete the "red" turn restriction twice – which might be related to the fact that this part of the intersection could be reached also from the opposite end of the selected from way (heading south, making a u-turn, taking the same way back (as a via way) and going into the selected to way.

I noticed a few (possibly) related issues:

• adding a no-u-turn restriction at either end of the selected from way causes the no-u-turn icons to be activated at both ends of the way (although only one turn restriction relation is created)
• if a only-straight-on restriction is present at the south end of the selected from way, adding another only-straight-on restriction at the north end of the same way causes the other only-straight-on restriction relation to be removed.

this reminds me a bit of #4849

[tyrasd]

adding a no-u-turn restriction at either end of the selected from way causes the no-u-turn icons to be activated at both ends of the way (although only one turn restriction relation is created)

this is actually a regression introduced by 0d262e5 for #4928. 🤔

[bhousel]

wait, I think this was fixed in #4928
Isn't this a duplicate issue?
We should test in http://preview.ideditor.com/master/

[tyrasd]

no, unfortunately the fix from #4928 doesn't work in this situation (I've originally tested this with a locally checked out master branch, but http://preview.ideditor.com/master shows the same behavior), and introduced the above mentioned "no-u-turn reflection" regression.

[bhousel]

no, unfortunately the fix from #4928 doesn't work in this situation (I've originally tested this with a locally checked out master branch, but http://preview.ideditor.com/master shows the same behavior), and introduced the above mentioned "no-u-turn reflection" regression.

Ah good, thanks for checking 👍