Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker support #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add docker support #2

wants to merge 2 commits into from

Conversation

Firefishy
Copy link
Member

  • Lock required python packages
  • Add Docker support
  • Add GHA to build and publish docker container to github (arm64 + amd64)

@Firefishy Firefishy changed the title Add docker Add docker support Dec 13, 2022
tomhughes
tomhughes reviewed Dec 13, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@tomhughes
Copy link
Member

I have to say I wasn't really expecting the container definition to be in the OSQA repository. I was expecting it to be something separate...

Also I guess "choose container system" in openstreetmap/operations#807 is resolved in favour of docker?

@Firefishy
Copy link
Member Author

Firefishy commented Dec 13, 2022 •
edited
Loading

I have to say I wasn't really expecting the container definition to be in the OSQA repository. I was expecting it to be something separate...

OSQA is dead. Easiest just to "hijack" the codebase (with our mods) and add the additional functionality for adding Docker. Adding git into a docker to checkout a repo to me feels like an antipattern.

Also I guess "choose container system" in openstreetmap/operations#807 is resolved in favour of docker?

Commented on openstreetmap/operations#807 ticket with options for "container system". For now plain old docker + systemd + chef is good enough.

@Firefishy Firefishy mentioned this pull request Dec 13, 2022
Closed
@Firefishy
Add Docker support
8ee2dd4 
Signed-off-by: Grant Slater <github@firefishy.com>
@Firefishy
Copy link
Member Author

Firefishy commented Dec 14, 2022 •
edited
Loading

Updates:

  • Removed confd and replaced with gettext envsubst
  • Better comments for Dockerfile
  • Updated to docker-compose.yml postgres 14
  • Allow override of default UID/GID at built time by using ARGS (build time only environment variables)

@Firefishy Firefishy mentioned this pull request Mar 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhughes tomhughes tomhughes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Firefishy @tomhughes