Vote screen and revamped chatbox #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chatbox can now receive a message history to display
|
HOW TO REVIEW:
|
Open
Chatbox can now receive a message history to display
…-and-revamped-chatbox
|
Marked this ready for review as this code might as well be in the game already. The vote UI is not done, but it is nice to have even as a placeholder. |
nicemicro
requested changes
Apr 20, 2021
There was a problem hiding this comment.
I found bugs:
- There is no rolescreen
- No one gets infiltrator (broken role distribution?)
- In some cases, confirming a vote only deactivates the button I voted on, and if I click on an other button, it asks for confirmation, but doesn't change the vote.
- Skip doesn't do anything (is it intended like that?)
- Voting is never over nor any indication of number of votes can be seen
If any of the things I mentioned is out of the scope of the current PR, just let me know.
Comment on lines
-17
to
+32
| var enabledRoles: Array = ["infiltrator", "detective", "agent"] | ||
| var roles: Dictionary = {"infiltrator": {"percent": float(2)/7, "amount": 1, "mustAssign": true, "team": 1}, | ||
| var enabledRoles: Array = ["traitor", "detective", "default"] | ||
| var roles: Dictionary = {"traitor": {"percent": float(2)/7, "amount": 1, "mustAssign": true, "team": 1}, | ||
| "detective": {"percent": float(1)/7, "amount": 1, "mustAssign": false, "team": 0}, | ||
| "agent": {"percent": 0, "amount": 0, "mustAssign": false, "team": 0}} | ||
| "default": {"percent": 0, "amount": 0, "mustAssign": false, "team": 0}} | ||
| var players: Dictionary = {} | ||
| var playerRoles: Dictionary = {} | ||
| var playerColors: Dictionary = {enabledRoles[0]: Color(1,0,0),# infiltrator | ||
| var playerColors: Dictionary = {enabledRoles[0]: Color(1,0,0),# traitor | ||
| enabledRoles[1]: Color(0,0,1),# detective | ||
| enabledRoles[2]: Color(1,1,1)}# agent | ||
| enabledRoles[2]: Color(1,1,1)}# default |
There was a problem hiding this comment.
The official terminology is "infiltrator" and "agent", please don't change it back.
Comment on lines
-78
to
-81
| func update_ui(ui_name: String, ui_data: Dictionary = {}): | ||
| if not ui_list.keys().has(ui_name): | ||
| push_error("update_ui() called with invalid ui name " + ui_name) | ||
| emit_signal("update_ui", ui_name, ui_data) |
There was a problem hiding this comment.
why are these functions here removed?
Comment on lines
-115
to
-121
|
|
||
| func state_changed_priority(old_state, new_state, priority): | ||
| if priority != 0: | ||
| return | ||
| if new_state == GameManager.State.Normal: | ||
| # needs to call _on_ready to connect signals, before roles are assigned | ||
| open_ui("rolescreen") |
There was a problem hiding this comment.
By deleting this, the rolescreen doesn't appear in the end of the turn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
NOTES
res://assets/ui/lobbyui/voteui/res://assets/ui/common/elements/chatboxbase/