Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workflows] Fix the existing checks failures due to workflows settings #300

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ZhangLe2016
Copy link
Contributor

@ZhangLe2016 ZhangLe2016 commented Sep 30, 2024

  • Update upload-artifact version from v2 to v4 for handling the build-release check failure:

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2.

Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

  • Update the ANDROID_NDK_HOME setting for fixing the build apk failure

ANDROID_NDK_HOME not set! Please set it to your Android NDK location!
Error: Process completed with exit code 1.

  • Install coreutils for realpath tool on MacOS for "macos" check failure

script/bootstrap.sh: line 138: realpath: command not found

for handling the build-release check failure:

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`.

Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
for fixing the build apk failure

  cd android
  ANDROID_ABI=armeabi-v7a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh
  ANDROID_ABI=arm64-v8a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh
  cd openthread_commissioner
  ./gradlew assembleDebug

  cp app/build/outputs/apk/debug/app-debug.apk \
     ot-commissioner-app-debug-0.0.1.apk
  shell: /usr/bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64

ANDROID_NDK_HOME not set! Please set it to your Android NDK location!
Error: Process completed with exit code 1.
for fixing the build apk failure

  cd android
  ANDROID_ABI=armeabi-v7a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh
  ANDROID_ABI=arm64-v8a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh
  cd openthread_commissioner
  ./gradlew assembleDebug

  cp app/build/outputs/apk/debug/app-debug.apk \
     ot-commissioner-app-debug-0.0.1.apk
  shell: /usr/bin/bash -e {0}
  env:
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64

ANDROID_NDK_HOME not set! Please set it to your Android NDK location!
Error: Process completed with exit code 1.
fix macos check

script/bootstrap.sh: line 138: realpath: command not found
for fixing the android-ndk check failure

cd android
  ANDROID_ABI=armeabi-v7a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh
  ANDROID_ABI=arm64-v8a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh
  shell: /usr/bin/bash -e {0}
ANDROID_NDK_HOME not set! Please set it to your Android NDK location!
Copy link
Member

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you update your PR description and commit message? The changes look like is not only about the upload-artifact version

@ZhangLe2016 ZhangLe2016 changed the title [workflows] update upload-artifact version from v2 to v4 [workflows] Fix the existing checks failures due to workflows settings Sep 30, 2024
@ZhangLe2016
Copy link
Contributor Author

ZhangLe2016 commented Sep 30, 2024

Thanks! Can you update your PR description and commit message? The changes look like is not only about the upload-artifact version

done, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants