-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workflows] Fix the existing checks failures due to workflows settings #300
Open
ZhangLe2016
wants to merge
5
commits into
openthread:main
Choose a base branch
from
ZhangLe2016:update-upload-artifact-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[workflows] Fix the existing checks failures due to workflows settings #300
ZhangLe2016
wants to merge
5
commits into
openthread:main
from
ZhangLe2016:update-upload-artifact-version
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for handling the build-release check failure: Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
for fixing the build apk failure cd android ANDROID_ABI=armeabi-v7a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh ANDROID_ABI=arm64-v8a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh cd openthread_commissioner ./gradlew assembleDebug cp app/build/outputs/apk/debug/app-debug.apk \ ot-commissioner-app-debug-0.0.1.apk shell: /usr/bin/bash -e {0} env: JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64 JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64 ANDROID_NDK_HOME not set! Please set it to your Android NDK location! Error: Process completed with exit code 1.
for fixing the build apk failure cd android ANDROID_ABI=armeabi-v7a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh ANDROID_ABI=arm64-v8a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh cd openthread_commissioner ./gradlew assembleDebug cp app/build/outputs/apk/debug/app-debug.apk \ ot-commissioner-app-debug-0.0.1.apk shell: /usr/bin/bash -e {0} env: JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64 JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.12-7/x64 ANDROID_NDK_HOME not set! Please set it to your Android NDK location! Error: Process completed with exit code 1.
fix macos check script/bootstrap.sh: line 138: realpath: command not found
for fixing the android-ndk check failure cd android ANDROID_ABI=armeabi-v7a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh ANDROID_ABI=arm64-v8a ANDROID_NDK_HOME=$(find $ANDROID_HOME/ndk -name "24.*") ./build-commissioner-libs.sh shell: /usr/bin/bash -e {0} ANDROID_NDK_HOME not set! Please set it to your Android NDK location!
wgtdkp
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you update your PR description and commit message? The changes look like is not only about the upload-artifact version
ZhangLe2016
changed the title
[workflows] update upload-artifact version from v2 to v4
[workflows] Fix the existing checks failures due to workflows settings
Sep 30, 2024
done, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error: This request has been automatically failed because it uses a deprecated version of
actions/upload-artifact: v2
.Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
ANDROID_NDK_HOME not set! Please set it to your Android NDK location!
Error: Process completed with exit code 1.
script/bootstrap.sh: line 138: realpath: command not found