This repository has been archived by the owner on May 23, 2023. It is now read-only.
Adding on span error callbacks #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to extend the functionality of Span._on_error to allow integrating other tools with the error handling of the spans. I don't think monkey patching is the good way to go on this, since also `Span._on_error` is a private method. Another approach would be having a `exit_callbacks` list to be executed on each `__exit__` call. I am not sure this funcionality exists on other languages implementation but it'd open the door to do more powerful integrtions with OpenTracing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to extend the functionality of Span._on_error to allow
integrating other tools with the error handling of the spans.
I don't think monkey patching is the good way to go on this, since also
Span._on_erroris a private method.Another approach would be having a
exit_callbackslist to be executedon each
__exit__call.I am not sure this funcionality exists on other languages implementation
but it'd open the door to do more powerful integrtions with OpenTracing.