Rename start_active_span() to start_active_scope(). #89
Conversation
…ing#64) * add Scope/ScopeManager interfaces * provide start_active_span and start_span with ScopeManager propagation * updating docstrings and tests
This includes ThreadLocalScopeManager in the ext submodule.
Python-examples import as testbed/ examples.
* Lint doc line lengths. * More formatting. * Apply a similar formatting as the requests library.
* Add proper documentation for MockTracer. * Further small refinements.
* Prepare the scope manager in testbed for production usage. * Mention the ScopeManager implementations in README.rst. * Prepare the inline documentation for our scope managers.
opentracing#90) Rename opentracing.ext.scope_manager to opentracing.scope_managers
|
To avoid confusion, I would say to don't comment this PR and keep the conversation going in the other PR (opentracing/opentracing-ruby#36). We have already many thoughts there so I guess it's better to ignore the Python PR at the moment. |
|
Good idea. 👍 |
|
Hey all, FYI: we will be postponing this change, and will release OT 2.0 today/tomorrow (Tuesday, July 10th). We will iterate and will get proper feedback on the rest of the supported languages, and will deprecate later on as needed (this will also be covered as part of opentracing/specification#122) Thanks for the feedback @indrekj and hope we can find a proper agreement rather soon ;) |
|
This could be actually affected by #107 - if we don't do any changes, then yeah, we could keep this renaming PR/iteration. Thoughts? |
For your consideration ;)
@tedsuo @yurishkuro @palazzem @pglombardo @indrekj