Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong config reading in cflow? #699

Closed
jpcbertoldo opened this issue Nov 8, 2022 · 1 comment · Fixed by #700
Closed

Wrong config reading in cflow? #699

jpcbertoldo opened this issue Nov 8, 2022 · 1 comment · Fixed by #700

Comments

@jpcbertoldo
Copy link
Contributor

anomalib/anomalib/models/cflow/lightning_model.py

Line 189 in 15625d6

fiber_batch_size=hparams.dataset.fiber_batch_size,

Shouldn't it be fiber_batch_size=hparams.model.fiber_batch_size ?

Instead of fiber_batch_size=hparams.dataset.fiber_batch_size. All other parameters are from hparams.model.

There is also this inconsistent permute_soft=hparams.model.soft_permutation.
I guess it should be permute_soft=hparams.model.permute_soft, no?
@jpcbertoldo jpcbertoldo mentioned this issue Nov 8, 2022
Merged
11 tasks
@jpcbertoldo
Copy link
Contributor Author

If that is the case, #700 fixes it.

samet-akcay added a commit that referenced this issue Nov 21, 2022
@jpcbertoldo @samet-akcay
Fix #699 (#700)
e66a17c 
* Update lightning_model.py

* Update config.yaml

* Update config.yaml

Co-authored-by: Samet Akcay <samet.akcay@intel.com>
NagatoYuki0943 added a commit to NagatoYuki0943/anomalib that referenced this issue Nov 22, 2022
@NagatoYuki0943
Merge pull request #16 from openvinotoolkit/main
6718a4e 
Fix openvinotoolkit#699 (openvinotoolkit#700)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #699 jpcbertoldo/anomalib
1 participant
@jpcbertoldo