Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📚 Add docs for the U-Flow model #1695

Merged
merged 4 commits into from
Feb 1, 2024
Merged

📚 Add docs for the U-Flow model #1695

merged 4 commits into from
Feb 1, 2024

Conversation

willyfh
Copy link
Contributor

@willyfh willyfh commented Jan 30, 2024 •
edited
Loading

📝 Description

Add missing docs for the U-Flow model

image

  • 🛠️ Fixes # (issue number)

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

@willyfh
update uflow module location
cc63cd6 
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
@willyfh
update path to the uflow diagram
d8dc037 
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
@willyfh
add uflow to the TOC tree
0b78b8e 
Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
@github-actions github-actions bot added the Docs label Jan 30, 2024
@willyfh willyfh marked this pull request as ready for review January 30, 2024 13:02
samet-akcay
samet-akcay approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks!

@willyfh
Copy link
Contributor Author

willyfh commented Feb 1, 2024

It seems that this failure in the pre-merge check is not related to the changes in the PR?

https://github.com/openvinotoolkit/anomalib/actions/runs/7730938469/job/21077687164?pr=1695#step:6:812

@samet-akcay
Copy link
Contributor

It seems that this failure in the pre-merge check is not related to the changes in the PR?

https://github.com/openvinotoolkit/anomalib/actions/runs/7730938469/job/21077687164?pr=1695#step:6:812

Yeah, the problem seems to be something else..

@samet-akcay samet-akcay merged commit 5b21dab into openvinotoolkit:main Feb 1, 2024
4 of 5 checks passed
adrianboguszewski pushed a commit to adrianboguszewski/anomalib that referenced this pull request Feb 9, 2024
@willyfh @samet-akcay @adrianboguszewski
📚 Add docs for the U-Flow model (openvinotoolkit#1695)
17ed98b 
* update uflow module location

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>

* update path to the uflow diagram

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>

* add uflow to the TOC tree

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>

---------

Signed-off-by: Willy Fitra Hendria <willyfitrahendria@gmail.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willyfh @samet-akcay