Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the imports to fit in OpenVINO 2023.3 #1756

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

prob1995
Copy link
Contributor

@prob1995 prob1995 commented Feb 20, 2024

πŸ“ Description

  • Fix the imports to fit in OpenVINO 2023.3 since "openvino.tools.mo" is no longer available.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@samet-akcay
Copy link
Contributor

@adrianboguszewski, can you have a look at this please?

@ashwinvaidya17
Copy link
Collaborator

Do we need to update requirements/openvino.txt as well?

@prob1995
Copy link
Contributor Author

Do we need to update requirements/openvino.txt as well?

OpenVINO 2023.3.0 (the current minimum supported version) also seems to support openvino.tools.ovc without issues. Since my tests worked well, updating is likely not necessary for this case.

@samet-akcay
Copy link
Contributor

samet-akcay commented Feb 20, 2024

@prob1995, pre-commit checks are failing due to some formatting issues. Can you run the following in your terminal

# Install the dev requirements
pip install -r requirements/dev.txt

# run the pre-commit checks
pre-commit run -a

@prob1995
Copy link
Contributor Author

@samet-akcay , I accidentally deleted a line break. It's fixed now! Thanks.

image

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@samet-akcay samet-akcay added this to the v1.0.0 milestone Feb 21, 2024
@samet-akcay samet-akcay merged commit 84ee0b7 into openvinotoolkit:main Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants